build: set hardening flags conditionally #8296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying -O0, FORTIFY_SOURCE=2 is still set via HARDENING_CFLAGS in Makefile-env.am. This option can be used to disable appending the HARDENING_CFLAGS to C/CXX flags. Signed-off-by: Karol Mroz <kmroz@suse.com>
|
#8301 is another way to fix this. |
Signed-off-by: Karol Mroz <kmroz@suse.com>
|
@tchaikov Yes it is. Let's get one of them committed so we can build with -O0. Though I suspect this is not much of a tragedy for the upcoming release :) |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last night I was stepping (actually hopping :D) through radosgw in gdb due to the optimization level set during compilation. I went digging where to set -O0... do_autogen.sh provides a "-O" option, however this broke compilation because FORTIFY_SOURCE=2 (along with a few others) are being set via HARDENING_CFLAGS in src/Makefile-env.am under a "if LINUX" conditional.
This patch tries to fix this by adding a "--without-hardening" option to do_autogen.sh/configure.ac to be used alongside "-d" and "-O".
First pass at fixing: http://tracker.ceph.com/issues/15263