osd: force update pg_stats for duplicated publish_stats_to_osd() #8385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may call publish_stats_to_osd() multiple times during boot/peering/recovering, in which cases we may want update some important info such as pg state and report it to user on time. However the statistics may stay in the pg_stat_queue for a long time in some abnormal cases, and we shall send the latest statistics instead, which means a force update of existing pg_stats in the pg_stat_queue is mandatory. Also, simplify pg_stat_queue_lock a little, which is good for extensibility. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may call publish_stats_to_osd() multiple times during boot/peering/recovering,
in which cases we may want update some important info such as pg state and report
it to user on time. However the statistics may stay in the pg_stat_queue for a
long time in some abnormal cases, and we shall send the latest statistics instead,
which means a force update of existing pg_stats in the pg_stat_queue is mandatory.
Also, simplify pg_stat_queue_lock a little, which is good for extensibility.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn