-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw: extend SIGHUP handler for realm reconfiguration #8765
Conversation
@cbodley I think SIGUSR2 is used internally in valgrind, so maybe we'd want to hook this with SIGHUP instead? tie it into the generic ceph configuration reloader somehow |
It looks like we could install a different handler for SIGHUP, which calls both |
is it also possible to hook the |
@theanalyst no, you cannot use ceph tell or injectargs with client ceph apps. |
@yehudasa updated to piggy-pack realm reconfiguration on SIGHUP. the default |
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley eventually we'd probably want to be able to update all config via sighup, but this is fine for now I think. |
As talk with cbodley in PR(ceph#16716), we shouldn't not mix such dangerous configuration reload with periodically SIGHUP for logs zip. Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com
rgw: revert PR #8765 Reviewed-by: Casey Bodley <cbodley@redhat.com>
As talk with cbodley in PR(ceph#16716), we shouldn't not mix such dangerous configuration reload with periodically SIGHUP for logs zip. Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com (cherry picked from commit 2f30bbb)
Adds a signal handler to trigger RGWRealmReloader to shut down and recreate RGWRados to reload the realm configuration and restart multisite sync.