Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: extend SIGHUP handler for realm reconfiguration #8765

Merged
merged 1 commit into from
May 25, 2016

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Apr 26, 2016

Adds a signal handler to trigger RGWRealmReloader to shut down and recreate RGWRados to reload the realm configuration and restart multisite sync.

@cbodley cbodley added the rgw label Apr 26, 2016
@yehudasa
Copy link
Member

@cbodley I think SIGUSR2 is used internally in valgrind, so maybe we'd want to hook this with SIGHUP instead? tie it into the generic ceph configuration reloader somehow

@cbodley
Copy link
Contributor Author

cbodley commented Apr 26, 2016

It looks like we could install a different handler for SIGHUP, which calls both RGWRealmReloader::handle_notify() and g_ceph_context->reopen_logs(). I'll give that a try.

@theanalyst
Copy link
Member

is it also possible to hook the ceph tell or injectargs into RGW somehow?

@yehudasa
Copy link
Member

@theanalyst no, you cannot use ceph tell or injectargs with client ceph apps.

@cbodley cbodley changed the title [RFC] rgw: add SIGUSR2 handler for realm reconfiguration [RFC] rgw: extend SIGHUP handler for realm reconfiguration May 17, 2016
@cbodley
Copy link
Contributor Author

cbodley commented May 17, 2016

@yehudasa updated to piggy-pack realm reconfiguration on SIGHUP. the default sighup_handler() only calls g_ceph_context->reopen_logs() though.. was the goal to extend this to reload ceph.conf too? i wasn't able to find any examples of other daemons doing this, and i don't think there's a thread-safe way to do it (the config observers look like a step in this direction, but they haven't been fully adopted)

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@yehudasa
Copy link
Member

@cbodley eventually we'd probably want to be able to update all config via sighup, but this is fine for now I think.

@cbodley cbodley changed the title [RFC] rgw: extend SIGHUP handler for realm reconfiguration rgw: extend SIGHUP handler for realm reconfiguration May 20, 2016
@oritwas oritwas merged commit 9e74d05 into ceph:master May 25, 2016
@cbodley cbodley deleted the wip-rgw-usr2 branch August 3, 2017 18:35
fangyuxiangGL added a commit to fangyuxiangGL/ceph that referenced this pull request Aug 4, 2017
As talk with cbodley in PR(ceph#16716), we shouldn't not mix such dangerous
configuration reload with periodically SIGHUP for logs zip.

Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com
yuriw added a commit that referenced this pull request Aug 21, 2017
rgw: revert PR #8765

Reviewed-by: Casey Bodley <cbodley@redhat.com>
cbodley pushed a commit to cbodley/ceph that referenced this pull request Dec 11, 2017
As talk with cbodley in PR(ceph#16716), we shouldn't not mix such dangerous
configuration reload with periodically SIGHUP for logs zip.

Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com
(cherry picked from commit 2f30bbb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants