-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.mailmap and .orgmap: organization affiliation #8767
Conversation
LGTM, after the comment is addressed |
@@ -339,6 +339,7 @@ Roald van Loon Consultancy <roald@roaldvanloon.nl> Roald J. van Loon <roald@roal | |||
Ruijie Networks <contact@ruijie.com.cn> Ning Yao <yaoning@ruijie.com.cn> | |||
Sandia National Laboratories <contact@sandia.gov> Jim Schutt <jaschut@sandia.gov> | |||
Samsung <contact@samsung.com> James Liu <james.liu@ssi.samsung.com> | |||
Samsung <contact@samsung.com> Jianjian Huo <samuel.huo@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here it should be Samsung <contact@samsung.com> <jianjian.huo@ssi.samsung.com>
, the mailmap will automatically associate your work email as primary
Done, thanks! |
@@ -339,6 +339,7 @@ Roald van Loon Consultancy <roald@roaldvanloon.nl> Roald J. van Loon <roald@roal | |||
Ruijie Networks <contact@ruijie.com.cn> Ning Yao <yaoning@ruijie.com.cn> | |||
Sandia National Laboratories <contact@sandia.gov> Jim Schutt <jaschut@sandia.gov> | |||
Samsung <contact@samsung.com> James Liu <james.liu@ssi.samsung.com> | |||
Samsung <contact@samsung.com> <jianjian.huo@ssi.samsung.com> Jianjian Huo <samuel.huo@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry I wasn't very clear last time, basically this line only needs the preferred (ie work) email.. so
Samsung <contact@samsung.com> Jianjian Huo <jianjian.huo@ssi.samsung.com>
would be the right entry.. as seen for other entries etc.
Signed-off-by: Jianjian Huo <jianjian.huo@ssi.samsung.com>
I see. had that fixed, thanks again! |
LGTM |
@theanalyst could you please merge it? thanks! |
Signed-off-by: Jianjian Huo jianjian.huo@ssi.samsung.com