cmake: build fixes #8770
Merged
cmake: build fixes #8770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@cbodley here's the PR |
|
lgtm |
| @@ -14,6 +14,9 @@ | |||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |||
| # GNU Library Public License for more details. | |||
| # | |||
| source $(dirname $0)/detect-build-env-vars.sh | |||
| CEPH_ROOT=${CEPH_ROOT:-..} | |||
There was a problem hiding this comment.
shouldn't need to set CEPH_ROOT in scripts that run detect-build-env-vars.sh
|
@dzafman This is the PR I was talking about in the core meeting |
|
@alimaredia The detect-build-env-vars.sh looks reasonable. I had a version that used $(pwd) to get an absolute path instead relative paths but I can't say that one is better than the other. |
|
@alimaredia make check test cluster tests are still failing, see jenkins output |
Closed
Signed-off-by: Ali Maredia <amaredia@redhat.com>
Signed-off-by: Ali Maredia <amaredia@redhat.com>
Signed-off-by: Ali Maredia <amaredia@redhat.com>
Signed-off-by: Ali Maredia <amaredia@redhat.com>
This makes it possible to run applicable unit tests without setting environment varibles after building with autotools. This will be reverted once autotools is deprecated. Signed-off-by: Ali Maredia <amaredia@redhat.com>
Signed-off-by: Ali Maredia <amaredia@redhat.com>
Signed-off-by: Ali Maredia <amaredia@redhat.com>
plugin_dir and compressor_dir not needed by test_compression_snappy & test_compression_zlib because they statically link compressor libraries. Signed-off-by: Ali Maredia <amaredia@redhat.com>
Signed-off-by: Ali Maredia <amaredia@redhat.com>
|
@dachary or anyone else, since this isn't causing Jenkins problems, can this be good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all the tests that need environment variables run in
make checkhave them set automatically as long as the tests are being executed out of the proper directory.