jewel: CephFSVolumeClient should isolate volumes by RADOS namespace #8787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As cephfs dir layout supports rados namespace in jewel, it would be good to use rados namespace instead of pool, since it is free, we always enforce namespace isolation for volumes. The meaning of "data_isolated" flag changed a bit, it's no longer used for security isolation, referring to physical isolation (i.e. potentially using different OSDs). Also, (de)authorize based on namespace. Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com> (cherry picked from commit 0e1d013)
Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com> (cherry picked from commit 7336806)
|
@xiaoxichen, can you resubmit this against master? We'll backport to Jewel but now that the release is out, everything should go to master unless it's a Jewel-only bugfix. :) |
|
@gregsfortytwo , this is already in master and actually this PR is doing the backport:) |
|
D'oh, sorry, I should have read more carefully! I'll let @jcsp or the backports team decide they're ready to merge this, otherwise I'll get it after it's had a few more test runs in master. |
|
@gregsfortytwo , cool thx. |
|
|
|
Oh, never mind the jewel branch of ceph-qa-suite already has the test for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/15631