Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM: hammer: ceph-disk: wrong log level of command #8988

Closed
wants to merge 4 commits into from
Closed

DNM: hammer: ceph-disk: wrong log level of command #8988

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2016

@ghost ghost mentioned this pull request May 9, 2016
Closed
@ghost
Copy link
Author

ghost commented May 9, 2016

Can it run CI again? It seems that build fail at the beginning.

@tchaikov tchaikov added this to the hammer milestone May 9, 2016
@tchaikov
Copy link
Contributor

tchaikov commented May 9, 2016

thanks Desmond!

Can it run CI again?

yeah, i think so. you can rebase your changes and "git push -f" to your remote branch to update this PR so the CI can be triggered again.

but i don't think it's a transient issue, see #8987, which also failed due to the same problem. so re-running the CI might also fail. but it's worth a try =)

@ghost ghost self-assigned this May 16, 2016
@ghost
Copy link
Author

ghost commented May 16, 2016

@jordan41177 could you please amend the description of the commits 8a66e89 and 9b91f69 to explain how the conflict was resolved and what it was about ?

@ghost ghost changed the title hammer: ceph-disk: wrong log level of command DNM: hammer: ceph-disk: wrong log level of command May 16, 2016
@ghost
Copy link
Author

ghost commented May 16, 2016

There should be no need to add new commits to a backport. If there is, you need to clearly explain why this is necessary, in the commit message. If you don't feel confortable writing this in english, give it a try in your native language first and we'll work from that.

ddiss and others added 4 commits May 18, 2016 10:07
@ddiss
ceph-disk: add --log-stdout parameter
9b6cb9c 
This can be used when ceph-disk is run by systemd services, to ensure
that output is captured in the journal.

Signed-off-by: David Disseldorp <ddiss@suse.de>
(cherry picked from commit 6cfb4b3)
@ldachary
ceph-disk: --verbose shows a stack trace on error
b2d11fc 
When running with --verbose, do not hide the stack trace from the user
when an exception is raised. It is most helpful to figure out when the
exception actually happened.

Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit 2fca91e)
@ldachary
ceph-disk: cosmetic: setup_logging function
f19d158 
Split the main function to extract the verbose handling part into the
setup_logging function.

Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit 60c22a9)
@ldachary
ceph-disk: support --verbose with --log-stdout
b3d9d51 
Set the LOG level as well as the channel level, otherwise the debug
messages are trimmed before they reach the channel. Also set the prefix
while we're at it.

http://tracker.ceph.com/issues/13180 Fixes: #13180

Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit 5aeca73)
@ghost
Copy link
Author

ghost commented May 18, 2016

@dachary
Sorry.. I missed some commits that can avoid the conflict happened.
I repushed and this time it doesn't need my fix anymore.
I want this backport fix because that I want to enhance the 'ceph-deploy' in all supported version.
There are fixed in Infernails and Jewel, but not yet in Hammer.

ceph/ceph-deploy#392

@smithfarm
Copy link
Contributor

@dachary Does this still need to be DNM?

@smithfarm
Copy link
Contributor

@dachary ping, does this still need to be DNM?

@ghost
Copy link
Author

ghost commented Aug 30, 2016

@dachary Done.

@liewegas
Copy link
Member

@jordan41177 ping? do we care about this anymore? please reopen if so; hamme ris getting old though!

@liewegas liewegas closed this Mar 28, 2017
@ghost
Copy link
Author

ghost commented Mar 29, 2017

@liewegas this's not important though. thx..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix
Projects
None yet
Milestone
hammer
5 participants
@tchaikov @smithfarm @liewegas @ddiss @ldachary