jewel: rbd-mirror: image sync needs to handle snapshot size and protection status #9050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
May 10, 2016 13:43
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 04db7dd) Conflicts: src/test/librbd/test_mock_Journal.cc: MockJournaler moved to new file
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit d0f7328)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit e6fba2b)
Initial implementation will resize the image (if needed) and create the snapshot. It is stubbed out for future state machines for handling object map and clones. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 8adc47f)
This feature is used by rbd-mirror during image bootstrap since it will directly create an empty object map. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit db16240)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 57a7fe0)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 468287b)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 2c65775)
The object maps are initialized to nonexistent at snapshot creation, so this operation is unnecessary. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit fe5d4a8)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 0d75f2c)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit adb1430)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit acca475)
When the snapshot sequence is out-of-sync between remote and local clusters (expected), the objects would not be written with the correct snapshot context. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit dd8f080)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit fa91919)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/15821