mon: fix 'mon metadata' for lone monitors, and enable listing all metadata at once #9097
Conversation
jcsp
changed the title
|
Hmm, don't merge just yet, I think I broke the multi-mon case by removing Monitor::metadata |
jcsp
changed the title
|
False jenkins failure (it's actually This should be good to go now |
jcsp
changed the title
|
thanks for fixing this. tested, lgtm! |
|
John, could you add the commit of jcsp#1 into your PR? |
Previously, writing to the store was only triggered when MMonMetadata was received from peers, so if you had a single mon then you would always get ENOENT from "mon metadata" Fixes: http://tracker.ceph.com/issues/15866 Signed-off-by: John Spray <john.spray@redhat.com>
Same as we already have for osd metadata, where if you omit the ID you get all daemons. Signed-off-by: John Spray <john.spray@redhat.com>
Same as mon and osd, leave out ID to get all. Signed-off-by: John Spray <john.spray@redhat.com>
to avoid copying of the std::map Signed-off-by: Kefu Chai <kchai@redhat.com>
|
@tchaikov I've merged your commit, thanks |
|
lgtm! thanks for merging my change, |
|
@jcsp per IRC with @athanatos, jobs 203924 and 203673 failed in http://pulpito.ceph.com/yuriw-2016-05-19_20:44:04-rados-wip-yuri-testing2-distro-basic-smithi/ Logs of one: /a/yuriw-2016-05-19_20:44:04-rados-wip-yuri-testing2-distro-basic-smithi/203924 2016-05-20T01:31:43.288 INFO:tasks.workunit.client.0.smithi030.stderr:/home/ubuntu/cephtest/workunit.client.0/cephtool/test.sh:798: test_mon_mds: ceph mds metadata |
Because 'r' was set inside loop, these would fail to set it (leaving ENOSYS) if no metadata is present. Signed-off-by: John Spray <john.spray@redhat.com>
Just because one OSD's metadata is missing, don't give up on outputting all the other OSDs' metadata. Signed-off-by: John Spray <john.spray@redhat.com>
|
@yuriw I've pushed updates, please retest |
Previously, writing to the store was only
triggered when MMonMetadata was received
from peers, so if you had a single mon then
you would always get ENOENT from "mon metadata"
Fixes: http://tracker.ceph.com/issues/15866
Signed-off-by: John Spray john.spray@redhat.com