rgw: fix manager selection when APIs customized #9243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osd: fix ReplicatedPG::fill_in_copy_get logic Reviewed-by: Sage Weil <sage@redhat.com>
osd: Trivial grammatical fix 'i' to 'I' Reviewed-by: songbaisen <song.baisen@zte.com.cn>
mon/Monitor: fix memory leak; add leaked key to tracked_conf_key Reviewed-by: Joao Eduardo Luis <joao@suse.de> Reviewed-by: Kefu Chai <kchai@redhat.com> Reviewed-by: Marcel Lauhoff <lauhoff@uni-mainz.de>
rbd-mirror: minor cleanup Reviewed-by: Jason Dillaman <dillaman@redhat.com>
test/rbd: document fsx option to keep data on success Reviewed-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: avoid potential deadlock Reviewed-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: don't unregister asok commands if image replayer start failed Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Fixes: ceph#15500 Signed-off-by: Mykola Golub <mgolub@mirantis.com>
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Better to do this on the projected map state. Signed-off-by: Sage Weil <sage@redhat.com>
Better to do this on the future map value. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
For both pg_temp and primary_temp, we want to calculate what the mapping *will* be after the inc is applied, and if the mapping is redundant (it matches what we would have gotten anyway), remove it. Removing the mapping might mean putting a 'remove' entry in the inc, or it might mean removing the proposed addition in the inc. Update the unit test to test both cases. Signed-off-by: Sage Weil <sage@redhat.com>
In `create_bucket`, we open an ioctx for domain root pool and never use it later, removing this. Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
cmake: build man pages Reviewed-by: Casey Bodley <cbodley@redhat.com>
That means that request is already complete and done with the manager. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
os/bluestore: fix permissions on StupidAllocator.cc, cleanups Reviewed-by: Sage Weil <sage@redhat.com>
os/bluestore: switch to bitmap freelist by default Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Fixes: http://tracker.ceph.com/issues/15613 Signed-off-by: Casey Bodley <cbodley@redhat.com>
Since above classes are implementation detail of OSD class move them to the .cc file. Signed-off-by: Michal Jarzabek <stiopa@gmail.com>
Signed-off-by: Michal Jarzabek <stiopa@gmail.com>
Otherwise, if it is reaped while we are waiting, it'll be a use-after-free. Fixes: http://tracker.ceph.com/issues/15870 Signed-off-by: Samuel Just <sjust@redhat.com>
no need to compute the cost a second time Signed-off-by: runsisi <runsisi@zte.com.cn>
...instead of the value set via set_snap_read(). This makes aio_sparse_read() consistent with aio_read(), which also accepts a snapid parameter. Signed-off-by: David Disseldorp <ddiss@suse.de>
pybind: expose fsync in cephfs binding. Reviewed-by: John Spray <john.spray@redhat.com>
librbd: initial python APIs to support mirroring Reviewed-by: Jason Dillaman <dillaman@redhat.com>
mon: optimize header file dependency. Reviewed-by: Sage Weil <sage@redhat.com>
osd: optimize header file dependency to decreace compile time when modify any file Reviewed-by: Sage Weil <sage@redhat.com>
os/bluestore/BlueStore: free space of bluestore should reduce spaces … Reviewed-by: Sage Weil <sage@redhat.com>
Signed-off-by: Loic Dachary <loic@dachary.org>
rgw: misc fix for test_multi.py Reviewed-by: Casey Bodley <cbodley@redhat.com>
tests: rm -fr /tmp/*virtualenv* Reviewed-by: Erwan Velu <erwan@redhat.com> Reviewed-by: Kefu Chai <kchai@redhat.com>
…md-fix rgw: fix updating account/container metadata of Swift API. Reviewed-by: Orit Wasserman <owasserm@redhat.com>
librados: use caller provided snapid for aio_sparse_read() Reviewed-by: Josh Durgin <jdurgin@redhat.com>
osd: fix crush location update on startup
common/config: cast OPT_U32 options using uint32_t Reviewed-by: Sage Weil <sage@redhat.com>
crush: fix the problem can not find the define item below the bucket Reviewed-by: Kefu Chai <kchai@redhat.com>
msg/async: Implement smarter worker thread selection Reviewed-by: Haomai Wang <haomai@xsky.com>
common/HeartbeatMap: print stack info of unhealth thread. Reviewed-by: Sage Weil <sage@redhat.com>
librados,osd: rados hints for future access pattern Reviewed-by: Samuel Just <sjust@redhat.com> Reviewed-by: Josh Durgin <jdurgin@redhat.com>
osd: Put background recovery tasks in the main OpWQ Reviewed-by: Sage Weil <sage@redhat.com>
librbd: write-after-write might result in an inconsistent replicated image Reviewed-by: Mykola Golub <mgolub@mirantis.com>
Disable: osd-scrub-repair.sh test-erasure-eio.sh test-erasure-code.sh These test are failing due to race conditions that is exposing bug http://tracker.ceph.com/issues/13937. Signed-off-by: David Zafman <dzafman@redhat.com>
test: Disable tests due to recovery race
Introduced: 27b6ec4 Signed-off-by: Samuel Just <sjust@redhat.com>
rgw: don't unregister request if request is not connected to manager Reviewed-by: Casey Bodley <cbodley@redhat.com>
common/: fix tests for prioritized_queue and wpq Reviewed-by: Greg Farnum <gfarnum@redhat.com>
robbat2
force-pushed
the
wip-15974
branch
3 times, most recently
from
3197b3d
to
593262a
Compare
When modifying rgw_enable_apis per RGW instance, such as for staticsites, you can end up with RESTManager instance being null in some cases, which returns a HTTP 405 MethodNotAllowed to all requests. Example configuration to trigger the bug: rgw_enable_apis = s3website Backport: jewel X-Note: Patch from Yehuda in private IRC discussion, 2016/05/20. Fixes: http://tracker.ceph.com/issues/15973 Fixes: http://tracker.ceph.com/issues/15974 Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>
|
Going to regenerate this against master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modifying rgw_enable_apis per RGW instance, such as for staticsites, you
can end up with RESTManager instance being null in some cases, which returns a
HTTP 405 MethodNotAllowed to all requests.
Example configuration to trigger the bug:
rgw_enable_apis = s3website
Backport: jewel
X-Note: Patch from Yehuda in private IRC discussion, 2016/05/20.
Fixes: http://tracker.ceph.com/issues/15973
Fixes: http://tracker.ceph.com/issues/15974
Signed-off-by: Robin H. Johnson robin.johnson@dreamhost.com