osd: fix omap digest compare when scrub #9271
Conversation
|
lgtm. Can you open a tracker ticket so we can mark this for backport? (And put the ticket url in the git commit message?) Thanks! |
Introduce by fe1c28d. Fixes: http://tracker.ceph.com/issues/16000 Signed-off-by: Xinze Chi <xinze@xsky.com>
XinzeChi
force-pushed
the
wip-fix-digest-hammer
branch
from
a8a75b3
to
d3eae0a
Compare
|
lgtm also. |
|
@liewegas This tag should be against hammer, untagged |
|
@XinzeChi since this master is also suffering from this issue, could you target master instead? and we can backport it to jewel and hammer. |
|
superseded by #9587 |
|
This only applies to hammer. |
Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
@liewegas This PR is in the latest round of hammer-backports integration tests, which passed a rados run (the only failures are a valgrind false positive that has since been fixed by ceph/teuthology#915 and http://tracker.ceph.com/issues/15139 which is an infrastructure issue with two of the tests) - for details, see: http://tracker.ceph.com/issues/15895#note-18 Do you think this PR is OK to merge? |
|
@liewegas @athanatos @dzafman This PR passed a /200 rados run on Ubuntu. None of the failures were reproducible. For details see http://tracker.ceph.com/issues/15895#note-18 Do you think it's OK to merge? |
|
I am ok with it if @dzafman is ok with it. |
|
@dzafman OK to merge? |
|
@smithfarm Ok to merge |
http://tracker.ceph.com/issues/16000
Introduce by fe1c28d.
The if logic would always return ture when deep-scrub non-omap object. And would trigger update the digest every deep-scrub.
Signed-off-by: Xinze Chi xinze@xsky.com