rgw/rados: initialize variable 'rados[]' to zero #9289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should memset rados[] to zero before using it, since it may be a unexpected pointer value while jumping to the *fail:* label to do the 'delete rados[i]' operation. in addition, we should also release cr_registry. Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
|
this reminded me of an old branch that switched |
|
retest this please |
|
@Yan-waller @cbodley I would also favor moving to std::vector here |
|
close because superceded by 9295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should memset
rados[]to zero before using it, sinceit may be a unexpected pointer value while jumping to the
fail:labelto do the
delete rados[i]operation.in addition, we should also release
cr_registry.Signed-off-by: Yan Jun yan.jun8@zte.com.cn