replace sgdisk subprocess calls with a helper #932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue 6979, but most importantly adds a couple of things to
ceph-disk
that should get used a bit more and hopefully used in the otherceph-*
scripts.subprocess.*
calls that were the same. By introducing a helper the repetition gets reduced and we now can handle errors forsubprocess
calls in one place.try/except
block at the end now just raisesSystemExit
vs. printing tostderr
and then callingsys.exit(1)
. Raising that exception achieves the same functionality and it is just one call and easier to read.This is how the error looks before these changes:
This is how it looks now: