hammer: mds: wrongly treat symlink inode as normal file/dir when symlink inode is stale on kcephfs #9404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is stale on kcephfs Signed-off-by: Zhi Zhang <zhangz.david@outlook.com> (cherry picked from commit 88b6d66) Conflicts: src/mds/Server.cc (hammer has req->head.args.open.flags instead of just flags)
smithfarm
added a commit
that referenced
this pull request
Jun 1, 2016
… normal file/dir when symlink inode is stale on kcephfs Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jun 27, 2016
… normal file/dir when symlink inode is stale on kcephfs Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jul 18, 2016
… normal file/dir when symlink inode is stale on kcephfs Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Jul 24, 2016
… normal file/dir when symlink inode is stale on kcephfs Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
@ukernel @gregsfortytwo This PR passed a cephfs integration run with two failures. Both failures are reproducible in both hammer-backports and hammer itself. One failure is due to http://tracker.ceph.com/issues/11258 ("cephfs-java ftruncate unit test failure") which is fixed in master, but the hammer backport is non-trivial. The second failure is probably an issue with some of the tests. For details, see http://tracker.ceph.com/issues/15895#note-21 Do you think this PR can be merged? |
|
Those test failures don't look like a problem to me. |
|
@jcsp OK to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16082