cephfs admin: remove test skip in TestCancelClone #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting: first run in the CI it reproduced the error. See #679 for updated details. |
phlogistonjohn
force-pushed
the
jjm-fix-issue679
branch
from
e5feb11
to
17bfdba
Compare
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
phlogistonjohn
added
do-not-merge
no-API
phlogistonjohn
force-pushed
the
jjm-fix-issue679
branch
4 times, most recently
from
2114b9f
to
da327e9
Compare
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
phlogistonjohn
force-pushed
the
jjm-fix-issue679
branch
2 times, most recently
from
6408c97
to
c998859
Compare
phlogistonjohn
force-pushed
the
jjm-fix-issue679
branch
from
df88425
to
4675755
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
jjm-fix-issue679
branch
2 times, most recently
from
c839197
to
b91e184
Compare
|
O M G.... It's actually passing!? I guess it's time to clean it up and actually propose this. |
phlogistonjohn
force-pushed
the
jjm-fix-issue679
branch
from
b91e184
to
1f8e522
Compare
|
I think commit message should mention that it re-enables the test case on both pacific and quincy. |
phlogistonjohn
force-pushed
the
jjm-fix-issue679
branch
from
1f8e522
to
2a593d1
Compare
Done |
|
@Mergifyio rebase |
This will re-enable the test case on ceph quincy and pacific. Signed-off-by: John Mulligan <jmulligan@redhat.com>
There was continued flakiness when the tests that enabled the cephfs mirroring module were enabled. This change adds another 200 ms delay to hopefully cover the time that might occur as the mgr has a new module enabled and restart. But unfortunately this is still a bit of a wild guess. Signed-off-by: John Mulligan <jmulligan@redhat.com>
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
jjm-fix-issue679
branch
from
2a593d1
to
cc97ee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will re-enable the test case on ceph quincy.
The test does not seem to be reproducing the error on my local machine with the latest quincy image. Making a PR to see if its more related to my system and can still reproduce on the CI or not.
Checklist