apiage: ability to promote apis tracked in JSON from preview to stable #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
changed the title
|
🎉 All dependencies have been resolved ! |
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
phlogistonjohn
force-pushed
the
jjm-stable-promoter
branch
from
9859867
to
bb91d33
Compare
|
@Mergifyio rebase |
Promote an API from preview to stable, after the build tags are removed from the Go source code. This mode can be used to help move apis that are now stable out of preview state in our api-status.json file. Signed-off-by: John Mulligan <jmulligan@redhat.com>
The intended workflow is to update the Go source code and then run `make api-promote` which will detect the changes to the ceph_preview tag(s) in the sources and then promote apis from preview to stable in the tracking json. I explicitly do not want apiage.py (or the makefile) to make changes to the source code. The contributor may or may not want to make changes incrementally, also some times a preview function may be moved to another source file. Plus, I simply think this is a job for a human. But we can avoid having to edit the JSON and markdown files afterward. Signed-off-by: John Mulligan <jmulligan@redhat.com>
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
jjm-stable-promoter
branch
from
bb91d33
to
4d5b006
Compare
ansiwen
added
the
no-API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #759
Fixes: #760
The intended workflow is to update the Go source code and then run
make api-promotewhich will detect the changes to the ceph_preview tag(s) inthe sources and then promote apis from preview to stable in the
tracking json.
I explicitly do not want apiage.py (or the makefile) to make changes to
the source code. The contributor may or may not want to make changes
incrementally, also some times a preview function may be moved to
another source file. Plus, I simply think this is a job for a human.
But we can avoid having to edit the JSON and markdown files afterward.