apiage fixes #774
Merged
apiage fixes #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
added
the
no-API
Probably caused by last minute changes to the pr that added the feature, it just needed the same initialization as the other section. Signed-off-by: John Mulligan <jmulligan@redhat.com>
I hadn't tested apiage well enough to see that the existing code didn't correctly handle the case when all or many apis were becoming stable all together. Things worked fine for a single function call, but not with many. This fix tries to only update the JSON when needed while correctly handling the case of multiple changes in one pkg at once. Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
force-pushed
the
jjm-apiage-fixes
branch
from
85006e1
to
7e5014a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The apiage script had a few bugs in the new ability to help promote and api from preview to stable. When I tried to use the script for real they raised their ugly heads. This fixes the issues that I saw today.