rgw:add "ListBucketsWithStat" function

[TheMoti]

Added new function ListBucketsWithStat to get all buckets of all users info (for admin keys only).

fixes #800

[TheMoti]

Hi @thotz,
Would you mind reviewing this PR? or if you're busy right now can you give an estimation on when it might get reviewed?
Thank you

[thotz]

Hey @TheMoti The change looks good to me, In go-ceph bindings for adding new apis, there are certain format need to be followed. @phlogistonjohn @anoopcs9 can guide through that

[TheMoti]

Hey @TheMoti The change looks good to me, In go-ceph bindings for adding new apis, there are certain format need to be followed. @phlogistonjohn @anoopcs9 can guide through that

Hi again,
I ran make fmt but no changes appeared. I'm not sure what should I change. Can you mention the problems? @thotz @anoopcs9

Many thanks

[phlogistonjohn]

I think @thotz meant make api-update - more details here and here.
It looks like you did that in the last commit of the series and the formatting of the doc comment itself looks OK.

I would suggest that for the scope of these changes are small and tightly related the commits be squashed together in one commit. While you do that it would be good to follow our format for commit messages: [topic]: [description] (and then details on later lines are optional). For your change I would suggest:

rgw: add ListBucketsWithStat function

Add an rgw api function that combines listing and stat'ing buckets.

If you're not familiar with the process of squashing patches with git, feel free to ask and we'll try to assist.

[TheMoti]

I think @thotz meant make api-update - more details here and here. It looks like you did that in the last commit of the series and the formatting of the doc comment itself looks OK.

I would suggest that for the scope of these changes are small and tightly related the commits be squashed together in one commit. While you do that it would be good to follow our format for commit messages: [topic]: [description] (and then details on later lines are optional). For your change I would suggest:

rgw: add ListBucketsWithStat function

Add an rgw api function that combines listing and stat'ing buckets.

If you're not familiar with the process of squashing patches with git, feel free to ask and we'll try to assist.

Done!
I'm not sure about the branch name format though. Is it ok?

[anoopcs9]

Done! I'm not sure about the branch name format though. Is it ok?

Branch name should not matter much but there is something I forgot to comment earlier(and I am sorry for the delay). New APIs in go-ceph are supposed to be tagged ceph_preview(in go build tags style) in a separate source file. Similarly corresponding test would also move to new file with ceph_preview build tag. For more details refer API Status in the Developers Guide and the API Stability Plan.

Thus you can have 2 commits, one which adds the API and another to deal with the API stability process by including the changes(to api-status.json and api-status.md) made as a result of make api-update.

[TheMoti]

@anoopcs9 Can you check new changes?

[thotz]

Since all new apis need to be added as separate file, I recommend filename should be similar to API like list_bucket_with.go than admin_bucket.go

[TheMoti]

Done.

Pull request has been modified.

[anoopcs9]

@Mergifyio rebase

[mergify]

⚠️ This pull request got rebased on behalf of a random user of the organization.
This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

[mergify]

rebase

✅ Branch has been successfully rebased

[anoopcs9]

@TheMoti Looks good in general.

Just a small nit: We prefer to have Signed-off-by: line included within each commit message. Can you please add that and push again? Sorry for dragging it out further 😕

[anoopcs9]

warning This pull request got rebased on behalf of a random user of the organization. This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

@phlogistonjohn Mergify needs some attention 😬

[phlogistonjohn]

Mergify needs some attention grimacing

Indeed. It'd be nice if they provided a link to some documentation.

I'll do it for them: https://blog.mergify.com/selecting-your-bot-account/

[anoopcs9]

@Mergifyio rebase

[mergify]

⚠️ This pull request got rebased on behalf of a random user of the organization.
This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

[mergify]

rebase

✅ Branch has been successfully rebased

[anoopcs9]

Thank you for bearing with us in fixing all nitpicks.

lgtm.

[TheMoti]

@thotz

[mergify]

⚠️ This pull request got rebased on behalf of a random user of the organization.
This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.