-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw/admin: Add ErrNoSuchSubUser #998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a related test? You may just expand TestHandleStatusError
to consider the error(NoSuchSubUser) which is being added.
Signed-off-by: Simon Jürgensmeyer <simon.juergensmeyer@hetzner-cloud.de>
Added. Unfortunately, I can't test it even though
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. Unfortunately, I can't test it even though ceph-client is installed via homebrew:
No worries, our CI has it covered.
=== RUN TestHandleStatusError
--- PASS: TestHandleStatusError (0.00s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks.
There was no Error for comparing the
NoSuchSubUser
code.Example error:
Reference:
https://github.com/ceph/ceph/blob/8a2a786e62ba1577dde990fef49d18f75efdd023/src/rgw/rgw_common.cc#L106C1-L106C52
Checklist
//go:build ceph_preview
make api-update
to record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyio
rebase
to rebase your PR when github indicates that the PR is out of date with the base branch.