Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display runs with filter sha1 #75

Merged
merged 3 commits into from
Sep 28, 2020
Merged

Conversation

kshtsk
Copy link
Contributor

@kshtsk kshtsk commented Sep 15, 2020

No description provided.

Kyr Shatskyy added 2 commits September 15, 2020 16:01
Fixes: https://tracker.ceph.com/issues/46805

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
Add 'Revision' column which shows sha1 for each run

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 15, 2020

Relates to ceph/paddles#90

Add text search form to the top right side of the run table
to satisfy the feature request:
"Add ability to search/filter runs by SHA1".

Fixes: https://tracker.ceph.com/issues/46805

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
@kshtsk
Copy link
Contributor Author

kshtsk commented Sep 25, 2020

Relates to ceph/paddles#90

This PR can be merged after the mentioned paddles PR.

@kshtsk kshtsk changed the title Wip filter sha1 Display runs with filter sha1 Sep 25, 2020
Copy link

@yuriw yuriw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need code review from @tchaikov

@djgalloway
Copy link

This looks good to me. Need @tchaikov's code review on the paddles PR though.

@yuriw
Copy link

yuriw commented Sep 28, 2020

@kshtsk
@tchaikov is OoO this week, @jdurgin approved, so merge at will

@djgalloway djgalloway merged commit de35fe4 into ceph:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants