Commits on Jul 13, 2016

1. Fix for GCC 5.4 (facebook#1157) …

   GCC 5.4 will complain (see also options_parser.cc):
   
       /home/abuild/rpmbuild/BUILD/arangodb-3.0.0r1/3rdParty/rocksdb/rocksdb/util/options_builder.cc: In function 'rocksdb::CompactionStyle rocksdb::{anonymous}::PickCompactionStyle(size_t, int, int, uint64_t)':
       /home/abuild/rpmbuild/BUILD/arangodb-3.0.0r1/3rdParty/rocksdb/rocksdb/util/options_builder.cc:29:7: error: 'log' is not a member of 'std'
              std::log(target_db_size / write_buffer_size) / std::log(kBytesForLevelMultiplier)));
              ^
       /home/abuild/rpmbuild/BUILD/arangodb-3.0.0r1/3rdParty/rocksdb/rocksdb/util/options_builder.cc:29:7: note: suggested alternative:
       In file included from /usr/include/features.h:365:0,
                        from /usr/include/math.h:26,
                        from /home/abuild/rpmbuild/BUILD/arangodb-3.0.0r1/3rdParty/rocksdb/rocksdb/util/options_builder.cc:6:
       /usr/include/bits/mathcalls.h:109:1: note:   'log'
        __MATHCALL_VEC (log,, (_Mdouble_ __x));

   

   fceller authored and tone.zhang committed Jul 13, 2016
   Copy the full SHA

   2ea2d92 View commit details

   Browse the repository at this point in the history

2. Move away from enum char value -1 …

   Summary: char is not signed in some platforms. Having negative values confuse those compilers.
   
   Test Plan: Run all existing tests.
   
   Reviewers: andrewkr, IslamAbdelRahman
   
   Reviewed By: IslamAbdelRahman
   
   Subscribers: leveldb, andrewkr, dhruba
   
   Differential Revision: https://reviews.facebook.net/D59619

   

   siying authored and tone.zhang committed Jul 13, 2016
   Copy the full SHA

   9142f29 View commit details

   Browse the repository at this point in the history