transition to python 3 #333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com>
|
This doesn't work.. I have no idea what i'm doing |
kshtsk
reviewed
Dec 16, 2019
| @@ -34,18 +34,18 @@ elif [ -f /etc/redhat-release ]; then | |||
| fi | |||
| fi | |||
|
|
|||
| virtualenv --no-site-packages --distribute virtualenv | |||
| virtualenv --no-site-packages --distribute virtualenv -p /usr/bin/python3 | |||
kshtsk
reviewed
Dec 16, 2019
|
|
||
| ./virtualenv/bin/pip install -r requirements.txt | ||
|
|
||
| # forbid setuptools from using the network because it'll try to use | ||
| # easy_install, and we really wanted pip; next line will fail if pip | ||
| # requirements.txt does not match setup.py requirements -- sucky but | ||
| # good enough for now | ||
| ./virtualenv/bin/python setup.py develop | ||
| ./virtualenv/bin/python3 setup.py develop |
There was a problem hiding this comment.
there is no need to provide python3 here, since ./virtualenv/bin/python is already pointed to python3 created in with virtualenv.
kshtsk
reviewed
Dec 16, 2019
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/python | |||
| #!/usr/bin/python3 | |||
There was a problem hiding this comment.
If this code is going to be run in the venv creates as about, there is no sense to use shebang at all.
kshtsk
reviewed
Dec 16, 2019
| @@ -43,7 +43,7 @@ def upload_objects(bucket, files, seed): | |||
| name_generator = realistic.names(15, 4, seed=seed) | |||
|
|
|||
| for fp in files: | |||
| print >> sys.stderr, 'sending file with size %dB' % fp.size | |||
| sys.stderr.write('sending file with size %dB\n' % fp.size) | |||
There was a problem hiding this comment.
Here and after for py2/py3 compatibility I guess you better use print from future package, like this:
from __future__ import print_function
.
.
.
print('sending file with size %dB' % fp.size, file=sys.stderr)
kshtsk
reviewed
Dec 16, 2019
| @@ -94,18 +94,18 @@ def _main(): | |||
|
|
|||
| bucket.set_acl('public-read') | |||
| keys = [] | |||
| print >> OUTFILE, 'bucket: %s' % bucket.name | |||
| print >> sys.stderr, 'setup complete, generating files' | |||
| OUTFILE.write('bucket: %s\n' % bucket.name) | |||
kshtsk
reviewed
Dec 16, 2019
| @@ -227,7 +227,7 @@ def files(mean, stddev, seed=None): | |||
| re-download the object and place the contents into a file called | |||
| ``foo``, the following should print two identical lines: | |||
|
|
|||
| python -c 'import sys, hashlib; data=sys.stdin.read(); print hashlib.md5(data[:-16]).hexdigest(); print "".join("%02x" % ord(c) for c in data[-16:])' <foo | |||
| python3 -c 'import sys, hashlib; data=sys.stdin.read(); print hashlib.md5(data[:-16]).hexdigest(); print "".join("%02x" % ord(c) for c in data[-16:])' <foo | |||
kshtsk
reviewed
Dec 16, 2019
| @@ -43,7 +43,7 @@ def upload_objects(bucket, files, seed): | |||
| name_generator = realistic.names(15, 4, seed=seed) | |||
|
|
|||
| for fp in files: | |||
| print >> sys.stderr, 'sending file with size %dB' % fp.size | |||
| sys.stderr.write('sending file with size %dB\n' % fp.size) | |||
There was a problem hiding this comment.
See the comment regarding future print.
kshtsk
reviewed
Dec 16, 2019
| @@ -57,7 +57,7 @@ def reader(bucket, worker_id, file_names, queue, rand): | |||
| traceback=traceback.format_exc(), | |||
| ), | |||
| ) | |||
| print "ERROR:", m | |||
| print("ERROR:", m) | |||
There was a problem hiding this comment.
This requires future python feature enabled in order it prints the same way as in py2
kshtsk
reviewed
Dec 16, 2019
| @@ -227,7 +227,7 @@ def files(mean, stddev, seed=None): | |||
| re-download the object and place the contents into a file called | |||
| ``foo``, the following should print two identical lines: | |||
|
|
|||
| python -c 'import sys, hashlib; data=sys.stdin.read(); print hashlib.md5(data[:-16]).hexdigest(); print "".join("%02x" % ord(c) for c in data[-16:])' <foo | |||
| python3 -c 'import sys, hashlib; data=sys.stdin.read(); print hashlib.md5(data[:-16]).hexdigest(); print "".join("%02x" % ord(c) for c in data[-16:])' <foo | |||
There was a problem hiding this comment.
Looks like dejavu, is it a code duplication here?
|
closing. as i think #336 is a better fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.