Invoke downburst with logging #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmick
requested review from
Abhishekvrshny and
zmc
and removed request for
Abhishekvrshny
zmc
requested changes
Mar 6, 2017
teuthology/provision/__init__.py
Outdated
|
|
||
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def _logfile(ctx, shortname): | ||
| if (ctx.config['archive_path']): |
There was a problem hiding this comment.
Is config['archive_path'] always present? Would it be safer to:
if ctx.config.get('archive_path', None) is not None:
?
Verbose output isn't verbose enough to matter, and can be helpful tracking down weirdness. Also, log to private file in case downburst hangs mid-operation, to avoid having to do any select() madness in teuthology. Signed-off-by: Dan Mick <dan.mick@redhat.com>
The more info the better; always log everything about the downburst execution to the teuthology log. Check for command failure by checking for returncode != 0 rather than "presence of stderr", since logging always happens to stderr. Signed-off-by: Dan Mick <dan.mick@redhat.com>
dmick
force-pushed
the
wip-downburst-logging
branch
from
38bf4d3
to
e6e50d9
Compare
zmc
approved these changes
Mar 7, 2017
zmc
added a commit
that referenced
this pull request
Mar 7, 2017
Looks like an argument was dropped to a string format(). Signed-off-by: Zack Cerza <zack@redhat.com>
zmc
added a commit
that referenced
this pull request
Mar 7, 2017
Looks like an argument was dropped to a string format(). Signed-off-by: Zack Cerza <zack@redhat.com>
zmc
added a commit
that referenced
this pull request
Mar 7, 2017
provision.downburst: Fix a bug in PR #1041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.