Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script,worker,suite: note down the rerun parameter in the first-job-in-suite #1198

Merged
merged 3 commits into from Sep 6, 2018

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Aug 3, 2018

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov
Copy link
Contributor Author

@zmc @yuriw ping?

@tchaikov tchaikov changed the title suite: do not bail out if results.log is not around script,worker,suite: note down the rerun parameter in the first-job-in-suite Aug 24, 2018
@tchaikov tchaikov force-pushed the wip-rerun branch 4 times, most recently from ffb5cec to 98ad0f8 Compare August 24, 2018 14:16
Copy link
Contributor

@yuriw yuriw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I will test it

@tchaikov
Copy link
Contributor Author

@yuriw this again involves changes on worker. so i am afraid we cannot test it without deploying it on teuthology.

@yuriw
Copy link
Contributor

yuriw commented Aug 24, 2018

@tchaikov I see 1st special job (http://pulpito.ceph.com/yuriw-2018-08-24_15:48:55-krbd-luminous-testing-basic-smithi/2941776/) actually marked as passed, can we exclude it from final pulpito results ?

see this http://pulpito.ceph.com/yuriw-2018-08-24_15:48:55-krbd-luminous-testing-basic-smithi/

@tchaikov
Copy link
Contributor Author

tchaikov commented Aug 24, 2018

@yuriw please see https://github.com/ceph/teuthology/pull/1198/files#diff-a92c4a52ae8a080fd2f137960b968f8cR193 . so, we need to deploy this change for testing it.

@yuriw
Copy link
Contributor

yuriw commented Aug 24, 2018

@tchaikov you mean merge ? I am ok with that. But I can't force merge, maybe you or @zmc ?

@smithfarm
Copy link
Contributor

Sorry, I don't have time to review this now. But @gregsfortytwo has been merging teuthology PRs in Zack's absence.

@tchaikov tchaikov force-pushed the wip-rerun branch 2 times, most recently from 0ff7c2f to 45bbc50 Compare August 24, 2018 17:16
@gregsfortytwo
Copy link
Member

Hmm, I really don't know how the rerun options work. Is there any risk of this impacting non-rerun users?
I'll see if I can dig into it next week some time.

Signed-off-by: Kefu Chai <kchai@redhat.com>
so it's more modular.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov force-pushed the wip-rerun branch 2 times, most recently from b02fd3c to 703f090 Compare August 31, 2018 03:20
@yuriw
Copy link
Contributor

yuriw commented Sep 2, 2018

@tchaikov @smithfarm @zmc Can we merge this ?

@@ -26,6 +26,9 @@
-N <num>, --num <num> Number of times to run/queue the job
[default: 1]

--first-in-suite Mark the first job in a suite so suite
can note down the rerun releated info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/rerun releated/rerun-related/ (typo, plus this is being used as an adjective so it needs a hyphen)

so we don't need to wait for the job to write result to for rerunning
the test suite. without this change, the "result" is normally the last
job in the suite to be scheduled, so it's likely we will not have the
results.log until the suite is almost completed. afer this change,
a "first-in-suite" job is scheduled as the first job to note down
the subset and seed to run the suite.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

tchaikov commented Sep 3, 2018

@smithfarm fixed and respushed.

@jdurgin jdurgin merged commit 6cf2f40 into ceph:master Sep 6, 2018
@tchaikov tchaikov deleted the wip-rerun branch September 7, 2018 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants