New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script,worker,suite: note down the rerun parameter in the first-job-in-suite #1198
Conversation
ffb5cec
to
98ad0f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I will test it
@yuriw this again involves changes on worker. so i am afraid we cannot test it without deploying it on teuthology. |
@tchaikov I see 1st see this http://pulpito.ceph.com/yuriw-2018-08-24_15:48:55-krbd-luminous-testing-basic-smithi/ |
@yuriw please see https://github.com/ceph/teuthology/pull/1198/files#diff-a92c4a52ae8a080fd2f137960b968f8cR193 . so, we need to deploy this change for testing it. |
Sorry, I don't have time to review this now. But @gregsfortytwo has been merging teuthology PRs in Zack's absence. |
0ff7c2f
to
45bbc50
Compare
Hmm, I really don't know how the rerun options work. Is there any risk of this impacting non-rerun users? |
Signed-off-by: Kefu Chai <kchai@redhat.com>
so it's more modular. Signed-off-by: Kefu Chai <kchai@redhat.com>
b02fd3c
to
703f090
Compare
@tchaikov @smithfarm @zmc Can we merge this ? |
scripts/schedule.py
Outdated
@@ -26,6 +26,9 @@ | |||
-N <num>, --num <num> Number of times to run/queue the job | |||
[default: 1] | |||
|
|||
--first-in-suite Mark the first job in a suite so suite | |||
can note down the rerun releated info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/rerun releated/rerun-related/ (typo, plus this is being used as an adjective so it needs a hyphen)
so we don't need to wait for the job to write result to for rerunning the test suite. without this change, the "result" is normally the last job in the suite to be scheduled, so it's likely we will not have the results.log until the suite is almost completed. afer this change, a "first-in-suite" job is scheduled as the first job to note down the subset and seed to run the suite. Signed-off-by: Kefu Chai <kchai@redhat.com>
@smithfarm fixed and respushed. |
Signed-off-by: Kefu Chai kchai@redhat.com