Fix opensuse provisioning support #1369

ryg- · 2019-11-27T13:53:33Z

task/selinux.py, orchestra/remote.py: disable SELinux for opensuse/suse distros
nuke/actions.py: added support for sle/opensuse distros

Signed-off-by: Roman Grigorev rgrigorev@suse.de

ceph-jenkins · 2019-11-27T13:53:35Z

Can one of the admins verify this patch?

kshtsk · 2019-11-27T15:49:45Z

ok to test

kshtsk · 2019-11-27T17:20:57Z

@susebot run deploy

susebot · 2019-11-27T18:03:26Z

Commit b0910b4 is OK.
Check tests results in the Jenkins job: https://ceph-ci.suse.de/job/pr-teuthology-deploy/61/

ryg- · 2019-11-29T14:49:13Z

@susebot run deploy

susebot · 2019-11-29T15:34:00Z

Commit b0910b4 is OK.
Check tests results in the Jenkins job: https://ceph-ci.suse.de/job/pr-teuthology-deploy/63/

toabctl

Would be nice to have a bit more of a description (in the commit msg) what is broken and why this is needed (see also https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#id7 )

ryg- · 2019-12-04T08:13:03Z

Ti be honest

Would be nice to have a bit more of a description (in the commit msg) what is broken and why this is needed (see also https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#id7 )

commit message is updated

kshtsk · 2019-12-09T20:08:03Z

suse:tier0 in sepia for this PR http://pulpito.ceph.com/kyr-2019-12-09_19:46:45-suse:tier0-nautilus-none-basic-smithi/

smithfarm · 2019-12-09T20:33:54Z

teuthology/nuke/actions.py

+            if dist_release in ['opensuse', 'sle']:
+                remote.run(
+                    args=['sudo', 'zypper', 'clean']
+                )


any reason why remote.run instead of remote.sh ?

yeah... looks like copy-paster

should I replace it?

This is a new code, why not to make it humanized?

Could you please use remote.sh like this:

remote.sh('sudo zippier clean')

kshtsk · 2019-12-09T20:51:00Z

suse:tier0 in sepia for this PR http://pulpito.ceph.com/kyr-2019-12-09_19:46:45-suse:tier0-nautilus-none-basic-smithi/

@ryg- the run above has used following file:

$ cat nautilus-overrides.yaml 
overrides:
  install:
    ceph:
      packages:
        deb: []
        rpm: []
    repos:
    - name: nautilus
      url: https://download.opensuse.org/repositories/filesystems:/ceph:/nautilus/openSUSE_Leap_15.1/
    - name: distro
      url: http://download.opensuse.org/distribution/leap/15.1/repo/oss/
    - name: update
      url: http://download.opensuse.org/update/leap/15.1/oss/

And the command:

teuthology-suite -m smithi -k none --ceph-repo https://github.com/ceph/ceph --ceph nautilus \
--suite-repo https://github.com/suse/ceph --suite-branch ses6-downstream-commits \
--filter opensuse --suite suse:tier0 -d opensuse -D 15.1 \
-v $PWD/nautilus-overrides.yaml --newest 100 --limit 1 -t refs/pull/1369/merge

I had to apply the patch from the #1373 to the teuthology in order to successfully schedule the run.

kshtsk · 2020-01-10T10:19:41Z

@susebot run deploy

susebot · 2020-01-11T22:38:08Z

Commit 626a6f3 is NOT OK.
Check tests results in the Jenkins job: https://ceph-ci.suse.de/job/pr-teuthology-deploy/95/

teuthology/orchestra/remote.py

teuthology/task/selinux.py

toabctl · 2020-01-17T09:11:18Z

@ryg- needs a rebase to fix the test failure ERROR: Package 'setuptools' requires a different Python: 2.7.12 not in '>=3.5'

ryg- · 2020-01-17T14:03:20Z

@susebot run deploy

toabctl · 2020-01-17T14:04:31Z

@susebot run deploy

susebot · 2020-01-17T14:18:35Z

Commit 4f8834e is NOT OK.
Check tests results in the Jenkins job: https://ceph-ci.suse.de/job/pr-teuthology-deploy/97/

smithfarm · 2020-01-17T20:24:37Z

Hi @ryg- This doesn't fix the kernel task, though, right? We still have to use --kernel none on opensuse.

smithfarm · 2020-01-17T20:58:29Z

teuthology/task/selinux.py

+            elif remote.os.name in ['opensuse', 'sle']:
+                msg = "Excluding {host}: \
+                        SELinux is not supported for '{os}' os_type yet"
+                log.info(msg.format(host=remote.shortname))


os=remote.os.name missing here, causing test failure:

2020-01-17T20:50:22.461 INFO:teuthology.run_tasks:Running task selinux... 2020-01-17T20:50:22.482 ERROR:teuthology.run_tasks:Saw exception from tasks. Traceback (most recent call last): File "/home/teuthworker/src/git.ceph.com_git_teuthology_wip-fix-opensuse-provisioning/teuthology/run_tasks.py", line 86, in run_tasks manager = run_one_task(taskname, ctx=ctx, config=config) File "/home/teuthworker/src/git.ceph.com_git_teuthology_wip-fix-opensuse-provisioning/teuthology/run_tasks.py", line 65, in run_one_task return task(**kwargs) File "/home/teuthworker/src/git.ceph.com_git_teuthology_wip-fix-opensuse-provisioning/teuthology/task/selinux.py", line 42, in __init__ super(SELinux, self).__init__(ctx, config) File "/home/teuthworker/src/git.ceph.com_git_teuthology_wip-fix-opensuse-provisioning/teuthology/task/__init__.py", line 36, in __init__ self.filter_hosts() File "/home/teuthworker/src/git.ceph.com_git_teuthology_wip-fix-opensuse-provisioning/teuthology/task/selinux.py", line 59, in filter_hosts log.info(msg.format(host=remote.shortname)) KeyError: 'os'

smithfarm

I am able to test this PR in the Sepia lab now. It's currently failing with KeyError: 'os' in the selinux task for the reason noted.

task/selinux.py, orchestra/remote.py: disable SELinux for opensuse/suse distros nuke/actions.py: added support for sle/opensuse distros Signed-off-by: Roman Grigorev <rgrigorev@suse.de>

smithfarm

Yay, with this and -k none I get through provisioning phase! It still fails in the install task but that can be fixed in a follow-up PR.

smithfarm · 2020-01-17T22:10:37Z

@susebot run deploy

susebot · 2020-01-17T22:24:07Z

Commit b31a085 is NOT OK.
Check tests results in the Jenkins job: https://ceph-ci.suse.de/job/pr-teuthology-deploy/98/

kshtsk · 2020-01-22T11:28:55Z

@susebot run deploy

ryg- · 2020-01-22T12:02:39Z

run in sepia started in 01/19
http://pulpito.ceph.com/ryg--2020-01-19_15:38:30-suse:tier0-nautilus-none-basic-smithi/

kshtsk · 2020-01-22T18:48:43Z

@susebot run deploy

susebot · 2020-01-22T19:39:24Z

Commit b31a085 is OK.
Check tests results in the Jenkins job: https://ceph-ci.suse.de/job/pr-teuthology-deploy/102/

kshtsk added test deploy-test teuthology deployment test labels Nov 27, 2019

toabctl reviewed Dec 4, 2019

View reviewed changes

ryg- force-pushed the wip-fix-opensuse-provisioning branch from b0910b4 to d9265e4 Compare December 4, 2019 08:12

toabctl previously approved these changes Dec 4, 2019

View reviewed changes

kshtsk requested review from smithfarm and gregsfortytwo December 9, 2019 20:08

smithfarm reviewed Dec 9, 2019

View reviewed changes

ryg- dismissed toabctl’s stale review via a2411f3 January 3, 2020 19:25

ryg- force-pushed the wip-fix-opensuse-provisioning branch 2 times, most recently from a2411f3 to 626a6f3 Compare January 3, 2020 21:22

kshtsk reviewed Jan 13, 2020

View reviewed changes

teuthology/orchestra/remote.py Outdated Show resolved Hide resolved

kshtsk reviewed Jan 13, 2020

View reviewed changes

teuthology/task/selinux.py Outdated Show resolved Hide resolved

ryg- force-pushed the wip-fix-opensuse-provisioning branch 2 times, most recently from 2ef24c2 to 54509bf Compare January 14, 2020 15:21

ryg- force-pushed the wip-fix-opensuse-provisioning branch from 54509bf to 4f8834e Compare January 17, 2020 13:19

smithfarm reviewed Jan 17, 2020

View reviewed changes

smithfarm suggested changes Jan 17, 2020

View reviewed changes

ryg- force-pushed the wip-fix-opensuse-provisioning branch from 66dda9a to b31a085 Compare January 17, 2020 21:36

Fix opensuse provisioning support

b31a085

task/selinux.py, orchestra/remote.py: disable SELinux for opensuse/suse distros nuke/actions.py: added support for sle/opensuse distros Signed-off-by: Roman Grigorev <rgrigorev@suse.de>

smithfarm approved these changes Jan 17, 2020

View reviewed changes

ceph deleted a comment from susebot Jan 22, 2020

kshtsk merged commit cae3b6e into ceph:master Jan 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix opensuse provisioning support #1369

Fix opensuse provisioning support #1369

ryg- commented Nov 27, 2019

ceph-jenkins commented Nov 27, 2019

kshtsk commented Nov 27, 2019

kshtsk commented Nov 27, 2019

susebot commented Nov 27, 2019

ryg- commented Nov 29, 2019

susebot commented Nov 29, 2019

toabctl left a comment

ryg- commented Dec 4, 2019

kshtsk commented Dec 9, 2019

smithfarm Dec 9, 2019

kshtsk Dec 9, 2019

ryg- Dec 9, 2019

kshtsk Dec 9, 2019

kshtsk Jan 13, 2020

ryg- Jan 14, 2020

kshtsk commented Dec 9, 2019 •

edited

kshtsk commented Jan 10, 2020

susebot commented Jan 11, 2020

toabctl commented Jan 17, 2020

ryg- commented Jan 17, 2020

toabctl commented Jan 17, 2020

susebot commented Jan 17, 2020

smithfarm commented Jan 17, 2020

smithfarm Jan 17, 2020

smithfarm left a comment

smithfarm left a comment

smithfarm commented Jan 17, 2020

susebot commented Jan 17, 2020

kshtsk commented Jan 22, 2020

ryg- commented Jan 22, 2020

kshtsk commented Jan 22, 2020

susebot commented Jan 22, 2020

Fix opensuse provisioning support #1369

Fix opensuse provisioning support #1369

Conversation

ryg- commented Nov 27, 2019

ceph-jenkins commented Nov 27, 2019

kshtsk commented Nov 27, 2019

kshtsk commented Nov 27, 2019

susebot commented Nov 27, 2019

ryg- commented Nov 29, 2019

susebot commented Nov 29, 2019

toabctl left a comment

Choose a reason for hiding this comment

ryg- commented Dec 4, 2019

kshtsk commented Dec 9, 2019

smithfarm Dec 9, 2019

Choose a reason for hiding this comment

kshtsk Dec 9, 2019

Choose a reason for hiding this comment

ryg- Dec 9, 2019

Choose a reason for hiding this comment

kshtsk Dec 9, 2019

Choose a reason for hiding this comment

kshtsk Jan 13, 2020

Choose a reason for hiding this comment

ryg- Jan 14, 2020

Choose a reason for hiding this comment

kshtsk commented Dec 9, 2019 • edited

kshtsk commented Jan 10, 2020

susebot commented Jan 11, 2020

toabctl commented Jan 17, 2020

ryg- commented Jan 17, 2020

toabctl commented Jan 17, 2020

susebot commented Jan 17, 2020

smithfarm commented Jan 17, 2020

smithfarm Jan 17, 2020

Choose a reason for hiding this comment

smithfarm left a comment

Choose a reason for hiding this comment

smithfarm left a comment

Choose a reason for hiding this comment

smithfarm commented Jan 17, 2020

susebot commented Jan 17, 2020

kshtsk commented Jan 22, 2020

ryg- commented Jan 22, 2020

kshtsk commented Jan 22, 2020

susebot commented Jan 22, 2020

kshtsk commented Dec 9, 2019 •

edited