py2 backports 20200514 #1477
Merged
py2 backports 20200514 #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Galloway <dgallowa@redhat.com> (cherry picked from commit 4e4a699)
py2: `str(signal.SIGHUP) == "1"` py3: `str(signal.SIGHUP) == "signal.SIGHUP"` Fixes: https://tracker.ceph.com/issues/45297 Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com> (cherry picked from commit bc101d5)
Signed-off-by: sunilkumarn417 <sunnagar@redhat.com> (cherry picked from commit 6fc0a1d)
the remote file is created using "ubuntu" user. in ubuntu xenial, superuser is able to write to that file using tar, it seems that "tar" starts another process when writing to the dest file specified by "-f", and that process does not have the privilege for writing that file. so when we are trying to archive a directory on ubuntu/focal test node, we have following error: ``` tar (child): /tmp/tmp.vkl0kAtc06: Cannot open: Permission denied tar (child): Error is not recoverable: exiting now tar: /tmp/tmp.vkl0kAtc06: Cannot write: Broken pipe tar: Child returned status 2 tar: Error is not recoverable: exiting now ``` and this is reproduciable with tar 1.30: ``` $ touch /tmp/helloworld $ mkdir /tmp/foobar $ sudo tar czf /tmp/helloworld -C /tmp/foobar -- . tar (child): /tmp/helloworld: Cannot open: Permission denied tar (child): Error is not recoverable: exiting now tar: /tmp/helloworld: Cannot write: Broken pipe tar: Child returned status 2 tar: Error is not recoverable: exiting now ``` but we can workaround this by writing the temp file using "ubuntu" user, like ``` sudo tar czf - -C /tmp/foobar -- . > /tmp/helloworld ``` Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 3acc2af)
This reverts commit 478bb3f. Fixes: https://tracker.ceph.com/issues/45255 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 759500c)
Signed-off-by: Vasu Kulkarni <vasu@redhat.com> (cherry picked from commit e8b9c68)
otherwise we could have ``` Traceback (most recent call last): File "<string>", line 1, in <module> NameError: name 'file' is not defined ``` Fixes: https://tracker.ceph.com/issues/45512 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 9874f7a)
Add --filter-all parameter to 'teuthology-suite' to allow precise test case selection. The --filter-in makes use of filter list with logical 'or' operation to include test cases. The --filter-out takes filter list and excludes any test case which match any from the filter list. This patch provides with 'and' logical operation for a given filter list. Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com> (cherry picked from commit 33593ff)
Signed-off-by: Vasu Kulkarni <vasu@redhat.com> (cherry picked from commit b035d2c)
Signed-off-by: Vasu Kulkarni <vasu@redhat.com> Fix unit test cases Signed-off-by: Vasu Kulkarni <vasu@redhat.com> (cherry picked from commit 7618b75)
|
@susebot run deploy |
|
Commit c6f90e6 is OK. |
|
why are you backporting py3 related fix to py2? |
as far as I can see those fixes are py2 compatible, and it would be good to have them if it will ease future backport of the conflicting code. |
|
which ones do you will to drop? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.