New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lock/ops.py: Fix retry mechanism for unlock_one #1675
Conversation
@susebot run deploy |
Commit 10ca8ee is NOT OK. |
deploy test ran into a pip error installing pulpito dependencies: ``` Downloading ipdb-0.8.1.zip (20 kB)
|
@susebot run deploy |
Commit 10ca8ee is OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on this fix! I'm requesting one change just to avoid surprising behavioral changes that are unrelated to the bug this fixes.
In unlock_one, we currently have a retry mechanism that is only triggered on a particular exception. With this change, we retry the request to unlock no matter what the cause of failure. Fixes: https://tracker.ceph.com/issues/50921 Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
10ca8ee
to
c25926b
Compare
@susebot run deploy |
Commit c25926b is OK. |
@zmc look ok now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In unlock_one, we currently have a retry mechanism that is only triggered on a particular exception. With this change, we retry the request to unlock no matter what the cause of failure.
Fixes: https://tracker.ceph.com/issues/50921
Signed-off-by: Aishwarya Mathuria amathuri@redhat.com