setup.cfg: add nose to "options.extras_require/test" #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some tests are using nose python package. since teuthology is responsible for preparing the deps to run the tests. let's add nose back to setup.cfg. the "nose" package was included in requirements.txt before 21372fd. in this change, it, it is brought back. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
idryomov
reviewed
Apr 23, 2022
since we don't need to be compatible with python2, let's stop using the six package. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
force-pushed
the
setup-add-nose
branch
2 times, most recently
from
204293f
to
6652f88
Compare
* move the dependencies from options.install_requires to options.extras_require if those dependencies are only used by tests. as per https://packaging.python.org/en/latest/discussions/install-requires-vs-requirements/#id5 > install_requires is a setuptools setup.py keyword that should be > used to specify what a project minimally needs to run correctly. * remove the duplicated dependencies from options.extras_require if they are also listed in options.install_requires. * update requirements.txt using "pip-compile --extra=test pyproject.toml", so requirements.txt can include the dependencies required by tests. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
force-pushed
the
setup-add-nose
branch
from
6652f88
to
903c61f
Compare
ljflores
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some tests are using nose python package. since teuthology is
responsible for preparing the deps to run the tests. let's add
nose back to setup.cfg.
the "nose" package was included in requirements.txt before
21372fd. in this change, it,
it is brought back.
Signed-off-by: Kefu Chai tchaikov@gmail.com