qa: correct line processing logic #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most runs don't use --no-nested-subset and for those that used --subset, the if conditions would correctly pickup "seed" (when it mattered). However, when --subset was not specified in the original run, the "seed" was not correctly picked up. Therefore, the result of inserting the "if no_nested_subset is None:" before the "elif seed is None:" caused it to never read the seed for most folks teuthology runs. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
djgalloway
approved these changes
Jun 6, 2022
batrick
added a commit
to batrick/teuthology
that referenced
this pull request
Jun 6, 2022
Most runs don't use --no-nested-subset and for those that used --subset, the if conditions would correctly pickup "seed" (when it mattered). However, when --subset was not specified in the original run, the "seed" was not correctly picked up. Therefore, the result of inserting the "if no_nested_subset is None:" before the "elif seed is None:" caused it to never read the seed for most folks teuthology runs. Fixes: ceph#1762 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
Accidentally closed this |
|
nevermind, found the reopen button! |
zmc
approved these changes
Jun 6, 2022
|
I was wrong - this fixes the main use-case! There appears to be a separate issue affecting some runs that cause incorrect behavior when the archive is unavailable, even when passing correct values, but I'm very glad to have this fixed. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most runs don't use --no-nested-subset and for those that used --subset,
the if conditions would correctly pickup "seed" (when it mattered).
However, when --subset was not specified in the original run, the "seed"
was not correctly picked up. Therefore, the result of inserting the "if
no_nested_subset is None:" before the "elif seed is None:" caused it to
never read the seed for most folks teuthology runs.
Signed-off-by: Patrick Donnelly pdonnell@redhat.com