Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teuthology/suite/run.py: Improve ScheduleFail exception #1924

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kamoltat
Copy link
Member

@kamoltat kamoltat commented Mar 7, 2024

As per: ceph/pulpito-ng#23

  1. Improve teuthology-schedule exceptions by utilizing ScheduleFail and GitError
  2. make teuthology.suite.main return job_count such that teuthology-api and Pulpito-ng can use it.
  3. edit teuthology.sh & start.sh such that we -x earlier for better output when watching the docker-compose do it's thing.

Fixes: https://tracker.ceph.com/issues/64820

@kamoltat kamoltat force-pushed the wip-ksirivad-teuth-suite-exception branch 3 times, most recently from 9ca70bd to 5fe4921 Compare March 13, 2024 20:05
@kamoltat kamoltat changed the title [DNM] teuthology/suite/run.py: Added some loggings and ScheduleFail exception teuthology/suite/run.py: Improve ScheduleFail exception Mar 13, 2024
@kamoltat kamoltat force-pushed the wip-ksirivad-teuth-suite-exception branch from 5fe4921 to 3f548c6 Compare March 13, 2024 21:02
@@ -356,7 +356,7 @@ def get_sha1s(project, committish, count):
if len(sha1s) != count:
log.debug('got response: %s', resp.json())
log.error('can''t find %d parents of %s in %s: %s',
int(count), sha1, project, resp.json()['error'])
int(count), sha1, project, resp.json())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor changes suggested; have you scheduled a run with this branch? I'd be curious to see it if so

teuthology/suite/run.py Outdated Show resolved Hide resolved
teuthology/suite/run.py Outdated Show resolved Hide resolved
do it for

/teuthology/teuthlogy.sh

&&

/start.sh

Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Added more loggings and utilizes exceptions e.g.,

ScheduleFail, GitError

Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
@kamoltat kamoltat force-pushed the wip-ksirivad-teuth-suite-exception branch from 3f548c6 to 27db304 Compare May 8, 2024 14:34
@kamoltat
Copy link
Member Author

kamoltat commented May 8, 2024

integration test failed:

Warning: RNING]: Skipping Galaxy server https://galaxy.ansible.com./ Got an unexpected
86.80 error when getting available versions of collection amazon.aws: Unknown error
86.80 when attempting to call Galaxy at 'https://galaxy.ansible.com/api/':
86.80 'CustomHTTPSConnection' object has no attribute 'cert_file'.
86.80 'CustomHTTPSConnection' object has no attribute 'cert_file'
86.80 ERROR! Unknown error when attempting to call Galaxy at 'https://galaxy.ansible.com/api/': 'CustomHTTPSConnection' object has no attribute 'cert_file'. 'CustomHTTPSConnection' object has no attribute 'cert_file'
------
Dockerfile:22
--------------------
  21 |     COPY requirements.txt requirements.yml ansible.cfg bootstrap /teuthology/
  22 | >>> RUN \
  23 | >>>     cd /teuthology && \
  24 | >>>     mkdir ../archive_dir && \
  25 | >>>     mkdir log && \
  26 | >>>     chmod +x /teuthology/bootstrap && \
  27 | >>>     PIP_INSTALL_FLAGS="-r requirements.txt" ./bootstrap
  28 |     COPY . /teuthology
--------------------
ERROR: failed to solve: process "/bin/sh -c cd /teuthology &&     mkdir ../archive_dir &&     mkdir log &&     chmod +x /teuthology/bootstrap &&     PIP_INSTALL_FLAGS=\"-r requirements.txt\" ./bootstrap" did not complete successfully: exit code: 1
Service 'teuthology' failed to build : Build failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants