misc.py: sh helper to log command and output #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
ghost
assigned 
| output = subprocess.check_output(command, stderr=subprocess.STDOUT, | ||
| shell=True) | ||
| except subprocess.CalledProcessError as e: | ||
| log.error(command + " error " + str(e.output)) |
There was a problem hiding this comment.
log.exception() would be useful here; it is the same as log.error() but adds the traceback for you.
It is the same as subprocess.check_output, only it log.debug the command being run as well as its output. Signed-off-by: Loic Dachary <loic@dachary.org>
|
Thanks for the review :-) I made the suggested changes and repushed. |
|
Refer to this link for build results (access rights to CI server needed): |
zmc
added a commit
that referenced
this pull request
Jul 7, 2015
misc.py: sh helper to log command and output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the same as subprocess.check_output, only it log.debug the command
being run as well as its output.
Signed-off-by: Loic Dachary loic@dachary.org