lock.py: not all virtual machines have a dedicated host #535
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
ghost
assigned 
|
I think this deserves a comment noting it's a codepath for openstack as opposed to downburst, no? |
|
@zmc right ! comment added |
|
Refer to this link for build results (access rights to CI server needed): |
|
@zmc I think http://jenkins.ceph.com/job/teuthology-pull-requests/1546/console is a false negative ? |
|
test this please |
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -265,6 +265,9 @@ def main(ctx): | |||
| for s in statuses: | |||
| if not s.get('is_vm', False): | |||
| continue | |||
| # when provisioning with an API, the host of the VM is unknown | |||
There was a problem hiding this comment.
Could you word this more specifically, like "e.g. an OpenStack API" please?
Gracefully handle the case where a virtual machine has no dedicated host. It's the case for OpenStack. Signed-off-by: Loic Dachary <loic@dachary.org>
|
I amended the comment to be more specific and re-pushed. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Thanks @dachary |
lock.py: not all virtual machines have a dedicated host
Gracefully handle the case where a virtual machine has no dedicated
host. It's the case for OpenStack.
Signed-off-by: Loic Dachary loic@dachary.org