Ensures that task list is a python list #561
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
ivotron
changed the title
|
Refer to this link for build results (access rights to CI server needed): |
ivotron
changed the title
| @@ -161,9 +161,12 @@ def validate_tasks(config): | |||
| # return the default value for tasks | |||
| return [] | |||
|
|
|||
| msg = 'Expecting (bullet) list of tasks instead of unordered map' | |||
There was a problem hiding this comment.
Maybe print out config['tasks'] here as well? Maybe: msg = "Expected a list of tasks and instead got: {0}".format(config['tasks'])
There was a problem hiding this comment.
Or even just log.info it somewhere before the assertion.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| for task in config['tasks']: | ||
| msg = ('kernel installation shouldn be a base-level item, not part ' + | ||
| 'of the tasks list') | ||
| msg = ("kernel installation shouldn't be a base-level item, not part " + |
There was a problem hiding this comment.
I think this should actually read "should be a base-level item"
There was a problem hiding this comment.
thought it was "shouldn't" . fixed below
|
Refer to this link for build results (access rights to CI server needed): |
|
This looks good to me; maybe squashing some commits (at least the most recent one) would be good |
|
how does squashing work for PRs on github? can I force an update to this On Tue, Jul 7, 2015 at 2:57 PM Zack Cerza notifications@github.com wrote:
|
|
Yeah, you can force push this branch |
|
Refer to this link for build results (access rights to CI server needed): |
|
done. switched back to single quotes |
|
Refer to this link for build results (access rights to CI server needed): |
* Modifies test for task list validation * Shows contents of config['tasks'] for error msg * Properly checks distinct failure conditions * Fixes typo on kernel task AssertionError
|
OK. Done with last modifications. Thanks! |
|
Refer to this link for build results (access rights to CI server needed): |
Ensures that task list is a python list Reviewed-by: Dan Mick <dmick@redhat.com> Reviewed-by: Zack Cerza <zcerza@redhat.com> Reviewed-by: Andrew Schoen <aschoen@redhat.com>
http://tracker.ceph.com/issues/12226