ansible: raise an AnsibleFailedError even when parsing fails #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If _handle_failures fails to parse the yaml in the ansible error log, it can still give the contents of the failure log to an AnsibleFailedError in it's unparsed form. I also changed the log.exception to log.error when an ParserError occurs as I think it was confusing some having that extra traceback in the log. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
|
Refer to this link for build results (access rights to CI server needed): |
zmc
added a commit
that referenced
this pull request
Aug 19, 2015
ansible: raise an AnsibleFailedError even when parsing fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If _handle_failures fails to parse the yaml in the ansible error log, it
can still give the contents of the failure log to an AnsibleFailedError
in it's unparsed form.
I also changed the log.exception to log.error when an ParserError occurs
as I think it was confusing some having that extra traceback in the log.
Signed-off-by: Andrew Schoen aschoen@redhat.com