openstack: resources hint is the max of all hints #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
An example of the new style at https://github.com/ceph/ceph-qa-suite/blob/master/suites/ceph-disk/basic/tasks/ceph-disk.yaml
|
Exactly one OpenStack resources hint can be included in a given job, as
part of an existing facet. It is error prone because it is sometimes not
trivial to figure out how a given job is composed and if two resources
hint are included only one of them will be taken into account which can
lead to problems difficult to diagnose. Another undesirable side effect
is to artificially increase resources usage. It is easier and more
reliable (from the test maintainer point of view) to increase the
resources of all jobs when a few need more RAM or disk rather than
trying to figure where to write the hints so that they are used by these
jobs and these jobs only.
Instead of being a fixed hint for a given job, the max of all hints
found in each facet is used. For instance, rados/thrash can have a facet
requiring that all jobs are given 3 devices.
cat rados/thrash/cluster/openstack.yaml
openstack:
- volumes:
count: 3
If one task in rados/thrash needs 16GB RAM instead of the default of 8GB
RAM, it can have:
cat rados/thrash/tasks/bigworkunit.yaml
task:
- workunit: highmemoryusage.sh
openstack:
- machine:
ram: 16 # GB
And a job composed of rados/thrash/{cluster/openstack.yaml
tasks/bigworkunit.yaml} is aggregated as the max of all resources,
including the default, that is:
task:
- workunit: highmemoryusage.sh
openstack:
- machine:
disk: 20 # GB
ram: 16 # GB
cpu: 1
volumes:
count: 3
size: 1 # GB
Signed-off-by: Loic Dachary <ldachary@redhat.com>
|
This is great! |
zmc
added a commit
that referenced
this pull request
Oct 23, 2015
openstack: resources hint is the max of all hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exactly one OpenStack resources hint can be included in a given job, as
part of an existing facet. It is error prone because it is sometimes not
trivial to figure out how a given job is composed and if two resources
hint are included only one of them will be taken into account which can
lead to problems difficult to diagnose. Another undesirable side effect
is to artificially increase resources usage. It is easier and more
reliable (from the test maintainer point of view) to increase the
resources of all jobs when a few need more RAM or disk rather than
trying to figure where to write the hints so that they are used by these
jobs and these jobs only.
Instead of being a fixed hint for a given job, the max of all hints
found in each facet is used. For instance, rados/thrash can have a facet
requiring that all jobs are given 3 devices.
cat rados/thrash/cluster/openstack.yaml
openstack:
- volumes:
count: 3
If one task in rados/thrash needs 16GB RAM instead of the default of 8GB
RAM, it can have:
cat rados/thrash/tasks/bigworkunit.yaml
task:
- workunit: highmemoryusage.sh
openstack:
- machine:
ram: 16 # GB
And a job composed of rados/thrash/{cluster/openstack.yaml
tasks/bigworkunit.yaml} is aggregated as the max of all resources,
including the default, that is:
task:
- workunit: highmemoryusage.sh
openstack:
- machine:
disk: 20 # GB
ram: 16 # GB
cpu: 1
volumes:
count: 3
size: 1 # GB
Signed-off-by: Loic Dachary ldachary@redhat.com