misc: ignore some unusable block devices #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dachary FYI ^^ |
|
@zmc will be pleased if you add unit tests in test_misc.py :-) |
|
Got the following error while testing (already sent via email but adding here for the record). 2015-12-14T14:37:36.305 INFO:teuthology.orchestra.run.target167114236178:Running: 'sudo blkid -o export -p /dev/vdc'
2015-12-14T14:37:36.731 ERROR:teuthology.contextutil:Saw exception from nested tasks
Traceback (most recent call last):
File "/home/ubuntu/teuthology/teuthology/contextutil.py", line 28, in nested
vars.append(enter())
File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
return self.gen.next()
File "/home/ubuntu/src/ceph-qa-suite_master/tasks/ceph.py", line 357, in cluster
devs = teuthology.get_scratch_devices(remote)
File "/home/ubuntu/teuthology/teuthology/misc.py", line 860, in get_scratch_devices
stderr=StringIO(),
File "/home/ubuntu/teuthology/teuthology/orchestra/remote.py", line 156, in run
r = self._runner(client=self.ssh, name=self.shortname, **kwargs)
File "/home/ubuntu/teuthology/teuthology/orchestra/run.py", line 378, in run
r.wait()
File "/home/ubuntu/teuthology/teuthology/orchestra/run.py", line 114, in wait
label=self.label)
CommandFailedError: Command failed on target167114236178 with status 2: 'sudo blkid -o export -p /dev/vdc'
|
robbat2
force-pushed
the
wip-get_scratch_devices
branch
from
1ad0241
to
4f52059
Compare
|
@dachary re-pushed with handling for the errors. |
If a block device is read-only, or is a cloud-init datasource, we should not change the content on it! This change detects most documented datasources as of 2015/12/10 from http://cloudinit.readthedocs.org/en/latest/topics/datasources.html It cannot detect datasources that are only detectable based on files on volume (eg config-drive v1) Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>
robbat2
force-pushed
the
wip-get_scratch_devices
branch
from
4f52059
to
57ce714
Compare
zmc
added a commit
that referenced
this pull request
Jan 27, 2016
misc: ignore some unusable block devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a block device is read-only, or is a cloud-init datasource, we should
not change the content on it!
This change detects most documented datasources as of 2015/12/10 from
http://cloudinit.readthedocs.org/en/latest/topics/datasources.html
It cannot detect datasources that are only detectable based on files on
volume (eg config-drive v1)
Signed-off-by: Robin H. Johnson robin.johnson@dreamhost.com