openstack: switch the default json output to dictionary #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but you misspelled "dictionary" :) |
ghost
changed the title
The python-openstackclient output may either be a list of Value/Field or a dictionary. Use the dictionary instead of the Value/Field form because it is easier to deal with. The former was chosen because of a bug that made it impossible to control the output. The bug still exists but is believed to be rare enough to ignore. Should it happen, a message recommending a corrective action and a comment on: https://bugs.launchpad.net/python-openstackclient/+bug/1510546 is displayed. Signed-off-by: Loic Dachary <loic@dachary.org>
|
@zmc reppushed with not doubble lettters this timme ;-) |
|
I was about the merge this but then realized it might break automated testing everywhere without manual intervention. Holding off for now. |
|
@zmc indeed: upgrading to a version of teuthology with this requires pip uninstall cliff-tablib as well |
|
@dachary on the other hand, this will only affect openstack deployments; I can easily make the change in our ovh cluster right before merging this, so I'll do that. |
zmc
added a commit
that referenced
this pull request
Jan 15, 2016
openstack: switch the default json output to dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python-openstackclient output may either be a list of Value/Field or
a dictionary. Use the dictionary instead of the Value/Field form
because it is easier to deal with. The former was chosen because of a
bug that made it impossible to control the output. The bug still exists
but is believed to be rare enough to ignore. Should it happen, a message
recommending a corrective action and a comment on:
https://bugs.launchpad.net/python-openstackclient/+bug/1510546
is displayed.
Signed-off-by: Loic Dachary loic@dachary.org