Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin gevent 1.0.2 #810

Merged
merged 1 commit into from Mar 7, 2016
Merged

pin gevent 1.0.2 #810

merged 1 commit into from Mar 7, 2016

Conversation

ghost
Copy link

@ghost ghost commented Mar 6, 2016

Signed-off-by: Loic Dachary loic@dachary.org

@ghost ghost assigned zmc Mar 6, 2016
http://tracker.ceph.com/issues/14990 Fixes: #14990

Signed-off-by: Loic Dachary <loic@dachary.org>
@ghost
Copy link
Author

ghost commented Mar 6, 2016

@ghost
Copy link
Author

ghost commented Mar 6, 2016

@zmc This gevent regression fails #809 and #808 which are just documentation changes.

@zmc
Copy link
Member

zmc commented Mar 7, 2016

Thanks @dachary. I'll dig into this a bit.

zmc added a commit that referenced this pull request Mar 7, 2016
@zmc zmc merged commit 8fb5f93 into ceph:master Mar 7, 2016
zmc added a commit that referenced this pull request Mar 7, 2016
Recently, gevent updated to 1.1.0, breaking a few things like misc.sh().
PR #810 pinned gevent to 1.0.2, but I wanted to properly investigate the
issue to not be stuck on an old version. Some git bisects later, I
discovered that gevent began patching the subprocess module by default
in:

gevent/gevent@fc73e9a

Unpinning gevent and also telling it not to patch subprocess fixes the
issue.

Signed-off-by: Zack Cerza <zack@redhat.com>
smithfarm pushed a commit to SUSE/teuthology that referenced this pull request Jul 1, 2016
Recently, gevent updated to 1.1.0, breaking a few things like misc.sh().
PR ceph#810 pinned gevent to 1.0.2, but I wanted to properly investigate the
issue to not be stuck on an old version. Some git bisects later, I
discovered that gevent began patching the subprocess module by default
in:

gevent/gevent@fc73e9a

Unpinning gevent and also telling it not to patch subprocess fixes the
issue.

Signed-off-by: Zack Cerza <zack@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants