Get dummy suite to run on openSUSE Leap in OpenStack

[smithfarm]

dummy suite runs to successful completion in OVH when these patches are applied to https://github.com/dachary/teuthology/tree/openstack

[smithfarm]

@dachary @zmc

[ghost]

Reviewed-by: Loic Dachary <ldachary@redhat.com>

[ghost]

@zmc I verified it works by looking at a dummy suite run @smithfarm gave me (the cluster is gone now but I saw it with my own eyes ;-)

[smithfarm]

test this please

[zmc]

test this please

[smithfarm]

==================================== ERRORS ====================================
_________ ERROR collecting teuthology/openstack/test/test_openstack.py _________
.tox/openstack/local/lib/python2.7/site-packages/_pytest/python.py:611: in _importtestmodule
    mod = self.fspath.pyimport(ensuresyspath=importmode)
.tox/openstack/local/lib/python2.7/site-packages/py/_path/local.py:650: in pyimport
    __import__(modname)
E     File "/home/jenkins-build/build/workspace/teuthology-pull-requests/teuthology/openstack/__init__.py", line 197
E       'ubuntu-12.04': 'https://cloud-images.ubuntu.com/precise/current/precise-server-cloudimg-amd64-disk1.img',
E                     ^
E   SyntaxError: invalid syntax
================== 1 pytest-warnings, 1 error in 0.17 seconds ==================

[smithfarm]

Comma missing at the end of this line - this commit was cherry-picked from a different branch and syntax error was introduced during conflict resolution.

[smithfarm]

Lesson learned - need to do python -m py_compile on files after conflict resolution.

[smithfarm]

Changelog:

• fix syntax error introduced during conflict resolution
• s/OpenSuse/openSUSE/ in commit message
• added Signed-off-by: Loic to the commit co-written with Loic

[smithfarm]

@zmc Any tests you want me to run?

[smithfarm]

Ping?

[zmc]

Apologies, @smithfarm! I hadn't seen your ping.

What's the reason for munging the name in opsys.os? The rest of your PR references 'opensuse' but in that module you're specifically dropping that and calling it 'suse'. I first noticed this in OS.from_os_release(), where I don't think we ought to be special-casing things.

[smithfarm]

@zmc I don't remember exactly, but I think I munged it to be compatible with https://github.com/ceph/teuthology/blob/master/teuthology/orchestra/opsys.py#L52

I think not munging is better, because openSUSE and SLE are distinct entities. (For now I am targeting openSUSE only.)

I will push a new version of this wip branch that uses "opensuse" everywhere. Thanks!

[smithfarm]

@zmc Does this address your concerns?

[smithfarm]

@zmc Can this be merged? @rjfd has more changes that were made on top of these.

[zmc]

Yes, this looks good! Sorry for the delay :)