Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] install.upgrade: add pre-upgrade sanity check #891

Closed
wants to merge 2 commits into from
Closed

[DNM] install.upgrade: add pre-upgrade sanity check #891

wants to merge 2 commits into from

Commits on Jan 25, 2017

  1. install.upgrade: implement pre-upgrade sanity check 

    Add a pre-upgrade sanity check to the install.upgrade task. This sanity check:

1. determines the version of Ceph installed on the remote ("installed_version")
2. determines the version of Ceph in the target gitbuilder repo
("upgrade_version")
3. if "installed_version" is greater than "upgrade_version", fail immediately

Since the upgrade itself cannot succeed if upgrade_version < installed_version,
it's better to fail before attempting the upgrade.

Before this patch, we were failing in the verify_package_version() sanity check
which is run after attempting (and failing) to upgrade the packages.

Fixes: http://tracker.ceph.com/issues/16521
Signed-off-by: Nathan Cutler <ncutler@suse.com>
    @smithfarm
    smithfarm committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    cb18082 View commit details
    Browse the repository at this point in the history

  2. install._upgrade_is_downgrade unit test 

    Signed-off-by: Nathan Cutler <ncutler@suse.com>
    @smithfarm
    smithfarm committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    64ffe83 View commit details
    Browse the repository at this point in the history