Added client_compression setting and pass it to driver #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhannus
changed the title
jhannus
force-pushed
the
client-compression
branch
from
1fa6e55
to
a20ff9e
Compare
| # | ||
| def client_compression | ||
| @client_compression | ||
| end |
There was a problem hiding this comment.
Do we need this in addition to the attr reader defined on line 36?
There was a problem hiding this comment.
To be honest, I don't think so. I added this to follow convention in keyspace.rb where other configuration options did the same.
|
Thanks the comments I'll address these later today after lunch 👍 |
jhannus
force-pushed
the
client-compression
branch
6 times, most recently
from
618d205
to
0ce5e5b
Compare
jhannus
force-pushed
the
client-compression
branch
from
0ce5e5b
to
a3051f3
Compare
|
@pezra I removed the mock all together since it was causing some conflicts in the rest of the test suite. I also removed the redundant getter for |
jhannus
changed the title
|
Merged. Thanks for the improvement. |
|
👍 |
|
released in 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cassandra client compression to Cequel gem.
This PR adds a new setting to the config to allow compression. It basically just passes it along to the Cassandra driver.
See: http://datastax.github.io/ruby-driver/features/#compression for more info.