Introduce tests using fixtures from the ipld/ipld repo. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I should also mention -- I added |
|
@smrz2001 I think this is mostly for your review. |
See commit message in the linked commit in the ipld/ipld submodule. (Calling both the dagjose and the dagjson hunks "data", as it was previously, suggested incorrect things: they are not that similar. The dagjson is the datamodel view, and that is *not* the same thing as a transliteration of the tokens that you'd get if you parsed the dag-jose as dag-cbor.)
|
Thanks so much, @warpfork! |
|
I'm going to merge this in and test/finalize it all together in #23 |
smrz2001
added a commit
that referenced
this pull request
Nov 26, 2021
* feat: `dag-jose` implementation using IPLD schema/code generation * cleanup * support for "flattened" JOSE objects * updates from review * comments and renaming * validate (then ignore) `link` when encoding * updates and test fixes * first pass of unit tests * update dependencies * test fixes * Introduce tests using fixtures from the ipld/ipld repo. (#24) * Introduce tests using fixtures from the ipld/ipld repo. * tweak some fixture hunk names. See commit message in the linked commit in the ipld/ipld submodule. (Calling both the dagjose and the dagjson hunks "data", as it was previously, suggested incorrect things: they are not that similar. The dagjson is the datamodel view, and that is *not* the same thing as a transliteration of the tokens that you'd get if you parsed the dag-jose as dag-cbor.) * test fixes * test fixes * test fixes * test fixes * cleanup docs * remove `link` from encoded JWS * fix up tests * minor updates and add TODOs * add CID matching to spec tests * remove travis.yml file and add TODOs to README.md * Update spec_test.go Remove redundant code * updates from review * update to latest ipld repo * use newest go-ipld-prime * check err from traversal Co-authored-by: Eric Myhre <hash@exultant.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added fixtures for dag-jose to the ipld/ipld repo. This diff adds code to run them; and a git submodule which drags in the ipld/ipld repo (so we've got something to run).
The fixtures themselves are materially the same as some other fixtures already used in another repo, but I've put them in a new format, and added some more kinds of related fixtures which I hope will increase legibility significantly.
The code both runs the test fixtures, and is also capable of regenerating them (or at least, some of them -- not the initial dag-jose itself (where would it come from?)). To do the later, simply run
go test ./dagjose/ -testmark.regen. (This is quite literally how I produced the rest of the data in ipld/ipld#151 .)(A git submodule? Yes. I think this is the least bad way to solve this linkage. Counterproposals welcome, though. I know many people don't consider them a joy to maintain.)
How Has This Been Tested?
The entire PR is tests :)
For the data: seealso ipld/ipld#151 . (That review is probably more critical than this one!)
Definition of Done
Before submitting this PR, please make sure: