Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sui wallet support #2638

Closed
wants to merge 3 commits into from

Conversation

0xzoz
Copy link

@0xzoz 0xzoz commented Jan 5, 2023

Description

This PR is to add SUI wallet support. Sui is a new layer 1 blockchain developed by Mysten Labs, it is in the early stages of launching and is part of the Move ecosystem that originated from the development work around Diem created at Meta

The PR adds SUI support to two of the packages - blockchain-utils-linking and blockchain-utils-validation. The motivation for this PR was while trying to develop an application integrating Ceramic and Sui(specifically creating a DID) there was no support to use a Sui wallet address when creating a DID session using the did-session package.

It is being added here as a draft in case the team wants to provide context or comments. Some unit testing is done but it is awaiting local development testing using Sui wallets and guidance around the addition of CAIP's for Sui network(see below)

How Has This Been Tested?

Local unit testing

  • run local unit test

Describe the tests that you ran to verify your changes. Provide instructions for reproduction.

  • [ X ] sui.test.ts in the respective packages (e.g. Add new tests to cover additional code)
  • Local dev testing - TBD

PR checklist

Before submitting this PR, please make sure:

  • I have tagged the relevant reviewers and interested parties - N/A
  • I have updated the READMEs of affected packages - N/A
  • I have made corresponding changes to the documentation - N/A

References:

Please list relevant documentation (e.g. tech specs, articles, related work etc.) relevant to this change, and note if the documentation has been updated.

@oed oed requested a review from zachferland January 6, 2023 09:20
@zachferland zachferland self-assigned this Jan 10, 2023
@zachferland
Copy link
Contributor

thanks for contributing!

For support in did-session, the following guide explains all the details https://did.js.org/docs/guides/add-chain-support/

This pr would add support in 3idconnect, which we are not longer accepting new chains right now, and is considered legacy support, sorry for the confusion (realizing now that the legacy guide was still in docs, going to remove)

Good news is the CAIP specs are an important part, and looks like those are open already, additionally a lot of what is here already will make it easy to add support in js-did/did-session, let us know if you need anything else

@0xzoz
Copy link
Author

0xzoz commented Jan 10, 2023

@zachferland thanks for the info and clarifying about 3idconnect. This was part of the initiative around adding it as a draft. Don't be sorry, this is all part of the origins grant program, I'm happy to be able to dig in and help. I will start working and add it to the linked repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants