Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfaces support for MIDs #2999

Merged
merged 13 commits into from
Oct 17, 2023
Merged

Conversation

PaulLeCam
Copy link
Contributor

Ensures MIDs can't be created using an interface as model metadata and relations can point to interface models.
Should also fix https://linear.app/3boxlabs/issue/CAT-2810/relations-can-be-optional-but-are-expected-to-be-required as part of the updated logic.

@PaulLeCam PaulLeCam self-assigned this Oct 17, 2023
@linear
Copy link

linear bot commented Oct 17, 2023

CAT-2810 Relations Can Be Optional But Are Expected to Be Required

Description

https://discord.com/channels/682786569857662976/1151881548862345276/1162327586890850314

 claimID: StreamID documentReference(model: "Claim")
Error: HTTP request to 'http://localhost:7007/api/v0/streams' failed with status 'Internal Server Error': {"error":"Error while parsing relation from field claimID: Invalid StreamID: Error: Unable to decode multibase string \"undefined\", base36 decoder only supports inputs prefixed with k"}

Technical Information

https://github.com/ceramicnetwork/js-ceramic/blob/develop/packages/stream-model-instance-handler/src/model-instance-document-handler.ts#L233

StreamID for relations is expected to be present.

CAT-2788 Update MID creation logic

Ensure MIDs can't be created on interface models

@PaulLeCam PaulLeCam merged commit e6f71df into develop Oct 17, 2023
5 checks passed
@PaulLeCam PaulLeCam deleted the feat/CAT-2788-mid-interface-check branch October 17, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants