-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes for telegram bot #17
Conversation
Hey @antonyip please check out the API documentation. We want something similar to the flow of the discord verification bot, but that works for telegram. |
This script is useful when testing: https://gist.github.com/oed/5d0e3923e7c1a9f3ff674a42ddabc622 |
Hi @oed, I'm pretty sure I've added all the functions, I am just having 1 last problem trying to generate a jwt to test. Let me know if you've seen this issue before. |
I figured out how to test it finally.. https://www.youtube.com/watch?v=xjWYWsJYaL4&ab_channel=AntonYip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Can you also add the confirm-telegram
endpoint to the API.md
file?
How can I test this?
@@ -142,6 +142,19 @@ functions: | |||
method: post | |||
cors: true | |||
path: /api/v0/confirm-discord | |||
verify-telegram: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename this to "confirm-telegram"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing, Discord is also using verify..
claimMgr, | ||
analytics | ||
) | ||
module.exports.verify_telegram = (event, context, callback) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to confirm. Would be a bit confusing otherwise. All other methods that accept the JWS use the confirm language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discord is also using verify.. Might want to make more change requests then..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, i just doubled-checked, everything there is using verify.. Would like a confirmation to do the rename..
Signed-off-by: Anton Yip <Anton_Yip@hotmail.com>
Done for confirm-telegram in API.md Steps to test
You should be able to proceed with the same steps in my video. |
Thanks @antonyip sorry for the delay here. I will get back to this soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this to be working locally!
Hello, first time working on this repo, please let me know if I made any mistakes..
Youtube demo:
https://www.youtube.com/watch?v=xjWYWsJYaL4&ab_channel=AntonYip
First Try of Youtube (OLD)
https://www.youtube.com/watch?v=P2hQGfVEJe8&ab_channel=AntonYip
Gitcoin:
https://gitcoin.co/issue/ceramicnetwork/ceramic/45/100025010