Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update bufbuild/buf-setup-action action to v1.17.0 #1522

Merged
merged 2 commits into from Apr 11, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 10, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
bufbuild/buf-setup-action action minor v1.16.0 -> v1.17.0

Release Notes

bufbuild/buf-setup-action

v1.17.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Signed-off-by: Renovate Bot <bot@renovateapp.com>
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #1522 (c15dd5c) into main (a38efe6) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1522      +/-   ##
==========================================
+ Coverage   53.85%   54.11%   +0.25%     
==========================================
  Files         122      122              
  Lines       13571    13585      +14     
==========================================
+ Hits         7309     7351      +42     
+ Misses       5638     5609      -29     
- Partials      624      625       +1     
Impacted Files Coverage Δ
internal/policy/policy.go 35.11% <ø> (ø)
internal/verify/junit/junit.go 82.88% <100.00%> (+2.47%) ⬆️

... and 3 files with indirect coverage changes

charithe
charithe previously approved these changes Apr 10, 2023
@charithe charithe changed the title chore(deps): update bufbuild/buf-setup-action action to v1.17.0 chore(deps): Update bufbuild/buf-setup-action action to v1.17.0 Apr 10, 2023
@renovate renovate bot changed the title chore(deps): Update bufbuild/buf-setup-action action to v1.17.0 chore(deps): update bufbuild/buf-setup-action action to v1.17.0 Apr 10, 2023
@oguzhand95
Copy link
Member

There used to be a //nolint:staticcheck comment on the line:

//nolint:staticcheck
p.Metadata.StoreIdentifer = storeIdentifier // TODO: Remove this after deprecated StoreIdentifer no longer exists
p.Metadata.StoreIdentifier = storeIdentifier

I might've removed it by running make lint in previous PRs. The reason it's removed;

internal/policy/policy.go:172:46: directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)
p.Metadata.StoreIdentifer = storeIdentifier //nolint:staticcheck

@charithe
Copy link
Contributor

Not sure what's happening. I think it's because golangci-lint used to have some linters disabled due to missing generics support. Now they seem to be back 🤷🏽

Signed-off-by: Charith Ellawala <charith@cerbos.dev>
@charithe charithe changed the title chore(deps): update bufbuild/buf-setup-action action to v1.17.0 chore(deps): Update bufbuild/buf-setup-action action to v1.17.0 Apr 11, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Apr 11, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@oguzhand95 oguzhand95 self-requested a review April 11, 2023 08:37
@oguzhand95 oguzhand95 merged commit c11163b into main Apr 11, 2023
21 of 22 checks passed
@oguzhand95 oguzhand95 deleted the renovate/gh-actions-deps branch April 11, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants