Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show phisher/member check UI when connected to any chain #7

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Show phisher/member check UI when connected to any chain #7

merged 3 commits into from
Mar 17, 2023

Conversation

nikugogoi
Copy link
Collaborator

@nikugogoi nikugogoi commented Mar 16, 2023 •
edited
Loading

Part of cerc-io/watcher-ts#321

  • Remove metamask wallet validation in members page for phisher/member check
    • Issue: Metamask needs to be connected to configured chain in app to check a phisher/member
    • Fix: The check for metamask connection to configured chain can be removed as phisher/member check is done using watcher GQL API
  • Convert delegationHash to hex string before broadcasting as JSON over p2p network

@nikugogoi nikugogoi self-assigned this Mar 16, 2023
@nikugogoi nikugogoi changed the title [WIP] Remove metamask check in UI and convert delegationHash to hex string [WIP] Show phisher/member check UI when connected to any chain Mar 16, 2023
@nikugogoi nikugogoi changed the title [WIP] Show phisher/member check UI when connected to any chain Show phisher/member check UI when connected to any chain Mar 17, 2023
@ashwinphatak ashwinphatak merged commit b5be553 into ng-peer Mar 17, 2023
@ashwinphatak ashwinphatak deleted the ng-remove-metamask branch March 17, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikugogoi nikugogoi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikugogoi @ashwinphatak