Configure exception class whitelist to be reraised by operations processors. #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essors. For example, if you use Pundit for authorization, you might raise a Pundit::NotAuthorizedError at some point during operations processing. If you want to use Rails' `rescue_from` macro to catch this error and render a 403 status code, you should add the `Pundit::NotAuthorizedError` to the `exception_class_whitelist`. `JSONAPI.configuration.exception_class_whitelist = [Pundit::NotAuthorizedError]`
lgebhardt
added a commit
that referenced
this pull request
Jul 6, 2015
Configure exception class whitelist to be reraised by operations processors.
|
Thanks! This adds some nice flexibility that was inadvertently lost with the InternalServer error change. |
|
I agree. It's nice to gracefully rescue internal server errors, but having the option to raise/rescue some classes is pretty important in my experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if you use Pundit for authorization, you might
raise a
Pundit::NotAuthorizedErrorat some point during operationsprocessing. If you want to use Rails'
rescue_frommacro tocatch this error and render a 403 status code, you should add
the
Pundit::NotAuthorizedErrorto theexception_class_whitelist.JSONAPI.configuration.exception_class_whitelist = [Pundit::NotAuthorizedError]