fix: Preserve existing branch status checks #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my previous PR for this (#7) I removed the checks value, however this results in an error when querying the GitHub API ("checks" is required). My updated approach is to first retrieve the existing set of checks on the repo, then when I update the branch protection rules, keep the checks the same. I've tested this with the cortex-api repo and it works as expected. Signed-off-by: Lucian Buzzo <lucian.buzzo@gmail.com>
LucianBuzzo
requested review from
20k-ultra,
SarjuHansaliya,
Pehesi97 and
nathaclmpaulino
Pehesi97
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous PR for this
(#7) I removed the checks value, however this results in an error when querying the GitHub API ("checks" is required). My updated approach is to first retrieve the existing set of checks on the repo, then when I update the branch protection rules, keep the checks the same. I've tested this with the cortex-api repo and it works as expected.