This repository has been archived by the owner on May 22, 2024. It is now read-only.
Dangerfile changelog checking improvements #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfaltermeier
requested review from
benbcai,
dkasper-was-taken,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
emilyrohrbough
approved these changes
May 28, 2019
emilyrohrbough
approved these changes
May 29, 2019
bjankord
approved these changes
Jun 5, 2019
ryanthemanuel
approved these changes
Jun 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enforces that every package that has changes in the src folder has a changelog modification. Additionally even if only new files have been added a changelog modification is still needed. All packages that need a changelog modification will be listed as opposed to simply stating that a changelog entry need to be included.
Additional Details
See cerner/terra-core#2418